Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-util/ninja: dep on media-gfx/graphviz #25570

Closed
wants to merge 1 commit into from

Conversation

laumann
Copy link
Contributor

@laumann laumann commented May 20, 2022

When USE=doc is set, graphviz dot is used as part of building the
documentation.

Closes: https://bugs.gentoo.org/846539
Signed-off-by: Thomas Bracht Laumann Jespersen t@laumann.xyz

When USE=doc is set, graphviz dot is used as part of building the
documentation.

Closes: https://bugs.gentoo.org/846539
Signed-off-by: Thomas Bracht Laumann Jespersen <t@laumann.xyz>
@laumann
Copy link
Contributor Author

laumann commented May 20, 2022

Tested by observing failure during:

USE=doc ebuild ./ninja-1.11.0.ebuild install

with media-gfx/graphviz uninstalled on the system. Installing media-gfx/graphviz lets the install phase complete successfully.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @laumann
Areas affected: ebuilds
Packages affected: dev-util/ninja

dev-util/ninja: @gentoo/chromium

Linked bugs

Bugs linked: 846539


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 20, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-20 11:06 UTC
Newest commit scanned: bf8db91
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ae4fda8345/output.html

@floppym
Copy link
Contributor

floppym commented May 20, 2022

Please update the live ebuild (9999) at the same time.

gentoo-bot pushed a commit that referenced this pull request May 20, 2022
When USE=doc is set, graphviz dot is used as part of building the
documentation.

Closes: https://bugs.gentoo.org/846539
Cloees: #25570
Signed-off-by: Thomas Bracht Laumann Jespersen <t@laumann.xyz>
Signed-off-by: Mike Gilbert <floppym@gentoo.org>
@stha09
Copy link
Contributor

stha09 commented May 20, 2022

Merged

@stha09 stha09 closed this May 20, 2022
@laumann laumann deleted the dev-util/ninja/dot-dep branch May 20, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
5 participants