Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-text/nfoview: revert PEP 517 migration #25572

Closed

Conversation

tillschaefer
Copy link
Contributor

causes location errors for include files

Closes: https://bugs.gentoo.org/846563
Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Till Schäfer till2.schaefer@uni-dortmund.de

causes location errors for include files

Closes: https://bugs.gentoo.org/846563
Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Till Schäfer <till2.schaefer@uni-dortmund.de>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @tillschaefer
Areas affected: ebuilds
Packages affected: app-text/nfoview

app-text/nfoview: @tillschaefer, @gentoo/proxy-maint

Linked bugs

Bugs linked: 846563


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 20, 2022
@juippis
Copy link
Member

juippis commented May 20, 2022

@arthurzam could you take a quick look? I'm fine with this, but is this the correct thing to do? (See the bug report too)

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-20 12:21 UTC
Newest commit scanned: 1df29b4
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a0c03aefa9/output.html

@arthurzam
Copy link
Member

@juippis Well, we can revert if needed, but the package should get fixed to use PEP517. The old usage of pre-PEP517 is legacry and going to become deprecated in some time.

@tillschaefer Could you investigate what is changing? I suggest to look at the list of files with and without PEP517 mode, and comparing them. Maybe you need to pass an argument to the build, use sed over setup.py, or maybe mv the file in src_install phase.

@tillschaefer
Copy link
Contributor Author

@tillschaefer Could you investigate what is changing? I suggest to look at the list of files with and without PEP517 mode, and comparing them. Maybe you need to pass an argument to the build, use sed over setup.py, or maybe mv the file in src_install phase.

In this particular case it may be not worth the time since upstream is currently migrating away from distutils to a make based build process. I am also currently in the final weeks to finish my PHD thesis and would like to do PEP 517 migration later if necessary.

@arthurzam
Copy link
Member

In this particular case it may be not worth the time since upstream is currently migrating away from distutils to a make based build process. I am also currently in the final weeks to finish my PHD thesis and would like to do PEP 517 migration later if necessary.

First of all, good luck with it. Secondly, no problems, we will do it later. If upstream moves to make, then no reason for now to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
5 participants