-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-text/nfoview: revert PEP 517 migration #25572
Conversation
causes location errors for include files Closes: https://bugs.gentoo.org/846563 Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Till Schäfer <till2.schaefer@uni-dortmund.de>
Pull Request assignmentSubmitter: @tillschaefer app-text/nfoview: @tillschaefer, @gentoo/proxy-maint Linked bugsBugs linked: 846563 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
@arthurzam could you take a quick look? I'm fine with this, but is this the correct thing to do? (See the bug report too) |
Pull request CI reportReport generated at: 2022-05-20 12:21 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
@juippis Well, we can revert if needed, but the package should get fixed to use PEP517. The old usage of pre-PEP517 is legacry and going to become deprecated in some time. @tillschaefer Could you investigate what is changing? I suggest to look at the list of files with and without PEP517 mode, and comparing them. Maybe you need to pass an argument to the build, use |
In this particular case it may be not worth the time since upstream is currently migrating away from distutils to a make based build process. I am also currently in the final weeks to finish my PHD thesis and would like to do PEP 517 migration later if necessary. |
First of all, good luck with it. Secondly, no problems, we will do it later. If upstream moves to make, then no reason for now to do it. |
causes location errors for include files
Closes: https://bugs.gentoo.org/846563
Package-Manager: Portage-3.0.30, Repoman-3.0.3
Signed-off-by: Till Schäfer till2.schaefer@uni-dortmund.de