dev-python/PyQt5 and friends: bumps and python3.11 #25577
Conversation
Pull Request assignmentSubmitter: @AndrewAmmerlaan dev-python/PyQt-builder: @gentoo/qt Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2022-05-20 17:16 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Update: Also added python 3.11 to dev-python/QtPy. Unfortunately pyside2 currently does not compile with python 3.11. Upstream development has mostly moved to pyside6 for Qt6, so I don't expect this to get fixed. Python 3.10 on pyside2 already required a couple of downstream patches. Instead I re-apply the same workaround we used before with python 3.10: if python 3.11 is enabled we hard depend on PyQt5 instead of allowing the user to choose which Qt4Python implementation to use. |
Pull request CI reportReport generated at: 2022-05-23 11:16 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Update2: Added python 3.11 to pytest-qt with the same workaround. @gentoo/qt A huge part of the scientific python software stack depends on this, please let me know if it is okay to merge this so I can continue testing the python packages higher up in the dependency tree with python 3.11. |
Pull request CI reportReport generated at: 2022-05-25 11:21 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
I was hoping for a quick sip-6.6.2 upstream release since there are a large number of unreleased fixes, but well... if this is blocking other work then I guess we can proceed, it's ~arch anyway.
There seems to be another issue with py3.11 though https://www.riverbankcomputing.com/pipermail/pyqt/2022-May/044668.html
|
Also note that I haven't tested this locally and I won't be able to do that for at least another week or two (hardware issues). |
That's unfortunate, there doesn't seem to be a patch for this yet. As I understand it, this will only surface in some applications. Perhaps we can proceed with adding python 3.11 here and then we'll find out which PyQt applications are affected and which ones aren't as we test them with python 3.11. We'll just have to wait with adding python 3.11 compatibility to those packages that are affected by this issue. |
Pull request CI reportReport generated at: 2022-05-26 08:51 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
On a side-note, PyQt6 is already prepared, will be adding it after qt6 is in tree which should happen soon'ish (just mentioning not to risk duplicating work, see old gentoo/qt#253 -- it also use sip pep517 which I guess PyQt5 should be able to use too 👀) |
I think we are going to want to add python 3.11 to both PyQt5 and PyQt6 anyway, since there are probably going to be many applications that aren't ready yet for Qt6 but might still work with python 3.11. |
Pull request CI reportReport generated at: 2022-05-26 10:46 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2022-06-01 09:41 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
@Pesa unfortunately this ends up blocking a fair bit (e.g. portage -> selinux -> pyqt5) Are you alright with proceeding on the basis @AndrewAmmerlaan mentions above? (Just being careful that rdeps actually work), or do you want to wait? |
|
Thanks! FWIW: I looked at veusz for a bug (don't use it myself, but wanted to give pointers in the right direction, so poked at it) and w/ new sip, it looks like some minor adjustments were needed: https://bugs.gentoo.org/823005#c10. Doesn't bother me but just a heads up in case other stuff breaks. It looks like veusz might just be the odd one out here, or at least this will slowly be a problem of the past w/ PEP517? |
Pull request CI reportReport generated at: 2022-06-07 20:56 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
@AndrewAmmerlaan Did you push an updated version already? I don't see setuptools in the sip ebuild. |
I did, but I see I made a mistake in the rebase and it ended up in the wrong commit. Will fix it in a bit. |
Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Pyside2 currently does not compile with py3.11 and it is not likely to get fixed soon because upstream development has moved to pyside6 for Qt6. Python 3.10 on pyside2 already required a bunch of patches to function. Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
This is what I get for doing late-night rebasing. It should be correct now. |
Pull request CI reportReport generated at: 2022-06-08 06:41 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
About that one, was just trying and it seems fixed if using python 3.11 beta3 (can only reproduce if I downgrade to beta1) Edit: was python/cpython#93250 |
This bumps some packages to the latest version and adds python 3.11 compatibility to all.
The patch is from upstream: https://www.riverbankcomputing.com/hg/sip/rev/3d656f0765f508ea9714b5e7c9ce00e304e6f600
And is required due to the following change in python 3.11:
CC: @gentoo/qt