Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mail-client/aerc: missing space between variables in live ebuild and metadata indentation #25593

Closed
wants to merge 2 commits into from

Conversation

arkamar
Copy link
Member

@arkamar arkamar commented May 22, 2022

Those are just two simple fixes.

Fixes: 721c5b6 ("mail-client/aerc: sync live")
Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @arkamar
Areas affected: ebuilds
Packages affected: mail-client/aerc

mail-client/aerc: williamh

At least one of the listed packages is maintained entirely by non-GitHub developers!

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added need assignment It was impossible to assign the PR correctly. Please assign it manually. no bug found No Bug/Closes found in the commits. labels May 22, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-22 09:21 UTC
Newest commit scanned: 6a885e3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/76ce7a42ec/output.html

@arkamar
Copy link
Member Author

arkamar commented May 24, 2022

@juippis could you maybe look at this one? It should be assigned to @williamh. It is not urgent at all.

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to stay away from packages maintained by other people, but this seems trivial enough to not care about maintainership.

While your update looks reasonable, I can't emerge this, so I don't know whether it fixes or breaks things :)

make -j16 'GOFLAGS=-mod=vendor -tags=notmuch' PREFIX=/usr VERSION=9999 all 
scdoc < doc/aerc.1.scd > aerc.1
scdoc < doc/aerc-search.1.scd > aerc-search.1
scdoc < doc/aerc-config.5.scd > aerc-config.5
scdoc < doc/aerc-imap.5.scd > aerc-imap.5
scdoc < doc/aerc-maildir.5.scd > aerc-maildir.5
scdoc < doc/aerc-sendmail.5.scd > aerc-sendmail.5
scdoc < doc/aerc-notmuch.5.scd > aerc-notmuch.5
scdoc < doc/aerc-smtp.5.scd > aerc-smtp.5
scdoc < doc/aerc-tutorial.7.scd > aerc-tutorial.7
scdoc < doc/aerc-templates.7.scd > aerc-templates.7
scdoc < doc/aerc-stylesets.7.scd > aerc-stylesets.7
go build -mod=vendor -tags=notmuch -ldflags "-X main.Version=9999 -X git.sr.ht/~rjarry/aerc/config.shareDir=/usr/share/aerc" -o aerc
# github.com/ddevault/go-libvterm
vendor/github.com/ddevault/go-libvterm/vterm.go:5:10: fatal error: vterm.h: No such file or directory
    5 | #include <vterm.h>
      |          ^~~~~~~~~
compilation terminated.
make: *** [Makefile:47: aerc] Error 2
 * ERROR: mail-client/aerc-9999::gentoo failed (compile phase):
 *   emake failed

@arkamar
Copy link
Member Author

arkamar commented May 24, 2022

Honestly, I found this typo by accident, I basically synced this line of live ebuild with other ebuilds and pushed it. The currently present live ebuild in master fails with the same error. I should probably report it to bugzilla...

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well not like this does any harm. But yeah, it doesn't work currently either.

@arkamar
Copy link
Member Author

arkamar commented May 24, 2022

Thanks!

@arkamar arkamar deleted the aerc branch May 24, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need assignment It was impossible to assign the PR correctly. Please assign it manually. no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants