Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-util/clion: add 2022.1.1, drop 2021.3.2 #25623

Closed
wants to merge 2 commits into from
Closed

dev-util/clion: add 2022.1.1, drop 2021.3.2 #25623

wants to merge 2 commits into from

Conversation

redstrate
Copy link
Contributor

I dropped 2021.3.2 in the process, I could add it back and slot it but I don't see any reason to keep it (I've been using 2022.1.1 for a bit now and it seems stable.)

I also noticed make_desktop_entry was called wrong, and it causes CLion to appear in lowercase in my DE. I changed it to proper casing and it doesn't affect any functionality.

Signed-off-by: Joshua Goins josh@redstrate.com

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @redstrate
Areas affected: ebuilds
Packages affected: dev-util/clion

dev-util/clion: @strahlc, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels May 24, 2022
Copy link
Contributor

@strahlc strahlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clion is now able to use an external ninja version, so please unbundle ninja in this version.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-24 14:26 UTC
Newest commit scanned: e95c255
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6312f1c434/output.html

@redstrate
Copy link
Contributor Author

clion is now able to use an external ninja version, so please unbundle ninja in this version.

Sorry I completely forgot about this change, I fixed it up now.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-24 14:51 UTC
Newest commit scanned: 11775d6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/037386b2ed/output.html

@strahlc
Copy link
Contributor

strahlc commented May 24, 2022

clion is now able to use an external ninja version, so please unbundle ninja in this version.

Sorry I completely forgot about this change, I fixed it up now.

Perfect, thanks.

@thesamesam
Copy link
Member

I dropped 2021.3.2 in the process, I could add it back and slot it but I don't see any reason to keep it (I've been using 2022.1.1 for a bit now and it seems stable.)

Could you cleanup old in a separate commit? It makes it easier to revert if necessary. But I usually prefer to keep n-1 around so that if something does break, folks can easily drop back.

Signed-off-by: Joshua Goins <josh@redstrate.com>
Signed-off-by: Joshua Goins <josh@redstrate.com>
@redstrate
Copy link
Contributor Author

I dropped 2021.3.2 in the process, I could add it back and slot it but I don't see any reason to keep it (I've been using 2022.1.1 for a bit now and it seems stable.)

Could you cleanup old in a separate commit? It makes it easier to revert if necessary. But I usually prefer to keep n-1 around so that if something does break, folks can easily drop back.

I separated the two now, and I also restored the GPG signing which I somehow managed to break :-p

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-26 13:41 UTC
Newest commit scanned: ad3f2b0
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/eb5defbda8/output.html

@gentoo-bot gentoo-bot closed this in 5056c61 Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
6 participants