Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-libs/nspr, dev-lang/spidermonkey:68: fix build on loong #25632

Merged
merged 5 commits into from May 26, 2022

Conversation

xen0n
Copy link
Member

@xen0n xen0n commented May 25, 2022

No description provided.

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels May 25, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-25 14:26 UTC
Newest commit scanned: 37d497c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3fcd9c0786/output.html

@xen0n xen0n changed the title dev-libs/nspr, dev-libs/nss: fix build on loong dev-libs/nspr, dev-lang/spidermonkey: fix build on loong May 25, 2022
@xen0n xen0n changed the title dev-libs/nspr, dev-lang/spidermonkey: fix build on loong dev-libs/nspr, dev-lang/spidermonkey:68: fix build on loong May 25, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-25 14:41 UTC
Newest commit scanned: 6bbbc2c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4c093836c2/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-25 15:11 UTC
Newest commit scanned: 5569976
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/015cf9c1ea/output.html

@xen0n xen0n marked this pull request as ready for review May 25, 2022 15:24
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-05-25 15:41 UTC
Newest commit scanned: 3d2aff7
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/48d2823046/output.html

@juippis juippis removed the assigned PR successfully assigned to the package maintainer(s). label May 25, 2022
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @xen0n
Areas affected: ebuilds
Packages affected: dev-lang/python, dev-lang/spidermonkey, dev-libs/nspr, dev-libs/nss, sys-devel/autoconf

dev-lang/python: @gentoo/python
dev-lang/spidermonkey: @gentoo/mozilla
dev-libs/nspr: @gentoo/mozilla
dev-libs/nss: @gentoo/mozilla
sys-devel/autoconf: @gentoo/base-system

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. and removed no bug found No Bug/Closes found in the commits. labels May 25, 2022
Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in here compiles on ~amd64 but I can only ack @gentoo/mozilla stuff - which I do, thanks!

xen0n added 2 commits May 26, 2022 08:55
Patch applied here has been running on real loong hardware since late
2021, simple and no problems so far.

See: gentoo#25632
Acked-by: Joonas Niilola <juippis@gentoo.org>
Signed-off-by: WANG Xuerui <xen0n@gentoo.org>
Patch applied here has been running on real loong hardware since late
2021, simple and no problems so far.

See: gentoo#25632
Acked-by: Joonas Niilola <juippis@gentoo.org>
Signed-off-by: WANG Xuerui <xen0n@gentoo.org>
@xen0n
Copy link
Member Author

xen0n commented May 26, 2022

The others are just keywordings, for which I do have real hardware to test on -- and tested. Merging ;-)

xen0n added 3 commits May 26, 2022 08:57
See: gentoo#25632
Signed-off-by: WANG Xuerui <xen0n@gentoo.org>
See: gentoo#25632
Signed-off-by: WANG Xuerui <xen0n@gentoo.org>
Only 4 test failures reported, normal function apparently not affected:

REGRESSIONS
    non262/Intl/Date/toLocaleTimeString_timeZone.js
    non262/Intl/DateTimeFormat/japanese-gannen-year.js
    non262/Array/regress-157652.js
    non262/regress/regress-422348.js

Compared with absolutely no spidermonkey, proceeding with keywording is
certainly the better choice. We'll have latest spidermonkey once LLVM
(and Rust) is ready.

Closes: gentoo#25632
Acked-by: Joonas Niilola <juippis@gentoo.org>
Signed-off-by: WANG Xuerui <xen0n@gentoo.org>
@gentoo-bot gentoo-bot merged commit 6866403 into gentoo:master May 26, 2022
@xen0n xen0n deleted the nss-nspr-loong branch May 26, 2022 01:13
xen0n added a commit to xen0n/loongson-overlay that referenced this pull request May 26, 2022
See: gentoo/gentoo#25632
Signed-off-by: WANG Xuerui <xen0n@gentoo.org>
xen0n added a commit to xen0n/loongson-overlay that referenced this pull request May 26, 2022
See: gentoo/gentoo#25632
Signed-off-by: WANG Xuerui <xen0n@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants