Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable pypy3 on smart-live-rebuild #25743

Closed
wants to merge 3 commits into from

Conversation

ArsenArsen
Copy link
Member

this enables smart-live-rebuild to be used when pypy3 is used to run emerge

NOTE: I didn't try FEATURES=test due to being out of time right now, I can do that before merging if so desired.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @ArsenArsen
Areas affected: ebuilds
Packages affected: app-portage/gentoopm, app-portage/smart-live-rebuild

app-portage/gentoopm: @mgorny
app-portage/smart-live-rebuild: @mgorny

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jun 3, 2022
@thesamesam
Copy link
Member

Please do, I suspect we haven't added it at some point for a reason.

Signed-off-by: Arsen Arsenović <arsen@aarsen.me>
Signed-off-by: Arsen Arsenović <arsen@aarsen.me>
@ArsenArsen
Copy link
Member Author

Ah, that might be why, pkgcore doesn't have pypy3. I wonder whether this is an oversight or a lack of support

@thesamesam
Copy link
Member

gentoopm only needs at least one of portage or pkgcore.

It's deeper than that, it's because even for portage, despite it having pypy3, the dep can't be satisfied on all profiles:

$ grep -rsin "pypy3" profiles/ | grep selinux
profiles/features/selinux/package.use.mask:24:sys-apps/portage python_targets_pypy3
profiles/features/selinux/package.use.mask:25:app-portage/elogv python_targets_pypy3
profiles/features/selinux/package.use.mask:26:app-portage/gentoolkit python_targets_pypy3
profiles/features/selinux/package.use.mask:27:app-portage/layman python_targets_pypy3
profiles/features/selinux/package.use.mask:28:app-portage/repoman python_targets_pypy3

The mask is:


# Brian Dolbec <dolsen@gentoo.org> (2014-09-17)
# mask pypy for several utilities due to incompatibility with libselinux
sys-apps/portage python_targets_pypy3
app-portage/elogv python_targets_pypy3
app-portage/gentoolkit python_targets_pypy3
app-portage/layman python_targets_pypy3
app-portage/repoman python_targets_pypy3

I have no idea what the incompatibility is. It kind of makes me think maybe libselinux and friends never got tested w/ pypy3. Anyway, we can just throw smart-live-rebuild and gentoopm into that mask, and we're good.

@ArsenArsen
Copy link
Member Author

tests appear to pass on pypy3 also

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-06-04 09:46 UTC
Newest commit scanned: 2ed4cad
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1d750b398c/output.html

@gentoo-bot gentoo-bot closed this in fe0bff9 Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants