New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sys-cluster/ucx: purge Werror from everything #25828
Conversation
Closes: https://bugs.gentoo.org/798051 Closes: https://bugs.gentoo.org/832966 Closes: https://bugs.gentoo.org/822132 Closes: https://bugs.gentoo.org/825338 Signed-off-by: Alessandro Barbieri <lssndrbarbieri@gmail.com>
Pull Request assignmentSubmitter: @Alessandro-Barbieri sys-cluster/ucx: @gentoo/cluster Linked bugsBugs linked: 825338, 798051, 822132, 832966 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
At least one of those bugs can be fixed properly trivially. |
Pull request CI reportReport generated at: 2022-06-09 09:46 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
ping |
# NOTE: This must be done after setting BASE_CXXFLAGS | ||
# | ||
ADD_COMPILER_FLAGS_IF_SUPPORTED([[-Wno-pointer-sign], | ||
- [-Werror-implicit-function-declaration], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we want to keep that.
@@ -1,21 +1,6 @@ | |||
https://bugs.gentoo.org/789762 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obviously you should put all the relevant bugs here instead.
pong? fix the trivial bit properly? |
Closes: https://bugs.gentoo.org/798051
Closes: https://bugs.gentoo.org/832966
Closes: https://bugs.gentoo.org/822132
Closes: https://bugs.gentoo.org/825338
Signed-off-by: Alessandro Barbieri lssndrbarbieri@gmail.com