Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-cluster/ucx: purge Werror from everything #25828

Closed
wants to merge 1 commit into from

Conversation

Alessandro-Barbieri
Copy link
Contributor

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @Alessandro-Barbieri
Areas affected: ebuilds
Packages affected: sys-cluster/ucx

sys-cluster/ucx: @gentoo/cluster

Linked bugs

Bugs linked: 825338, 798051, 822132, 832966


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jun 9, 2022
@thesamesam
Copy link
Member

At least one of those bugs can be fixed properly trivially.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-06-09 09:46 UTC
Newest commit scanned: e803c0b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1c65a0e3b8/output.html

@Alessandro-Barbieri
Copy link
Contributor Author

ping

# NOTE: This must be done after setting BASE_CXXFLAGS
#
ADD_COMPILER_FLAGS_IF_SUPPORTED([[-Wno-pointer-sign],
- [-Werror-implicit-function-declaration],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we want to keep that.

@@ -1,21 +1,6 @@
https://bugs.gentoo.org/789762
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously you should put all the relevant bugs here instead.

@thesamesam
Copy link
Member

ping

pong? fix the trivial bit properly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants