dev-db/redis: rework src_test #25831

arkamar · 2022-06-09T12:00:52Z

I think die should be used with all those scripts or is there a reason why it shouldn't?

gentoo-repo-qa-bot · 2022-06-09T12:21:04Z

Pull request CI report

Report generated at: 2022-06-09 12:21 UTC
Newest commit scanned: 1db63ef
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d8d4f41845/output.html

arkamar · 2022-06-09T12:39:59Z

I will append https://bugs.gentoo.org/649868 fix to this PR as well. I'm working on it.

arkamar · 2022-06-10T20:44:18Z

It took slightly longer than I thought but I believe it was for good thing. All tests seem to work now with usual default FEATURES.

gentoo-bot · 2022-06-10T20:48:07Z

Pull Request assignment

Submitter: @arkamar
Areas affected: ebuilds
Packages affected: dev-db/redis

dev-db/redis: @thesamesam

Linked bugs

Bugs linked: 649868, 756382

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2022-06-10T20:51:02Z

Pull request CI report

Report generated at: 2022-06-10 20:51 UTC
Newest commit scanned: b6c9740
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0f11f0471d/output.html

gentoo-repo-qa-bot · 2022-06-10T21:21:08Z

Pull request CI report

Report generated at: 2022-06-10 21:21 UTC
Newest commit scanned: 8971f91
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e9796ece51/output.html

thesamesam · 2022-06-10T23:35:55Z

dev-db/redis/redis-6.0.16.ebuild

 	fi
+
+	echo "./runtest ${runtestargs[@]}"


oh, nice, I have changed that.

thesamesam · 2022-06-10T23:36:30Z

dev-db/redis/redis-7.0.1.ebuild

@@ -55,9 +55,6 @@ PATCHES=(
 src_prepare() {
 	default

-	# unstable on jemalloc


We've lost this, is that ok?

Yes, it is ok. Sorry, I was too tired and lazy to write some summary of those commits yesterday, but it is actually explained in commit messages. This issue seems to affect 6.0 only, see fefe8b0. It was fixed in 6.2* and it does not affect 7.0* either, at least those tests work for me, see b325b5d.

It's my bad for not reading the commit messages! Great work here.

Signed-off-by: Petr Vaněk <arkamar@atlas.cz>

It is necessary to cal ./runtest directly from src_test function in order to be able to pass --clients parameter. Bug: https://bugs.gentoo.org/649868 Signed-off-by: Petr Vaněk <arkamar@atlas.cz>

This change makes tests to respect user MAKEOPTS jobs preference rather than running 16 test clients by default. Closes: https://bugs.gentoo.org/649868 Signed-off-by: Petr Vaněk <arkamar@atlas.cz>

Defrag tests with enabled jemalloc are fixed since version 6.2*, let's restore them back. Signed-off-by: Petr Vaněk <arkamar@atlas.cz>

It is possible to skip selected tests by --skiptest argument passed to runtest, which is cleaner than emptying the script file. Moreover, only "Active defrag*" tests are affected, therefore we can restore "Memory efficiency*" tests which are also part of memoryefficiency unit. Signed-off-by: Petr Vaněk <arkamar@atlas.cz>

oom-score-adj related unit tests fail when usersandbox or -userpriv FEATURES are set, therefore let's skip them. They were introduced as unit/oom-score-adj tests in 6.2.0 but they were backported to 6.0.7. Later, "CONFIG SET rollback on apply error" test was added in version 7.0.0 which also tries to adjust OOM score. Closes: https://bugs.gentoo.org/756382 Signed-off-by: Petr Vaněk <arkamar@atlas.cz>

gentoo-repo-qa-bot · 2022-06-11T21:01:21Z

Pull request CI report

Report generated at: 2022-06-11 21:01 UTC
Newest commit scanned: 5b0c6a3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/9c374cb90b/output.html

arkamar · 2022-06-11T21:04:43Z

Summary of last FP:

use of edo for all local test script calls
Use MAKEOPTS jobs to limit number of test clients, this change is in two commits, first one changes 5.0.14 only because it was necessary to introduce src_test function and the second addapts the rest of ebuilds where ./runtest script is already used.
defrag tests are restored in another commit in version 6.2* and 7.0*
only defrag tests are skipped in 6.0 in next commit
the last commit resolves problem with oom-score-adj related tests when usersanbox or -userpriv FEATURES are set.

thesamesam · 2022-06-12T20:48:53Z

Big thank you!

thesamesam · 2022-06-13T11:10:39Z

Also, if you're interested, you're free to join me in maintaining Redis.

gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jun 9, 2022

arkamar changed the title ~~dev-db/redis: add die for all local test scripts~~ WIP: dev-db/redis: add die for all local test scripts Jun 10, 2022

arkamar changed the title ~~WIP: dev-db/redis: add die for all local test scripts~~ dev-db/redis: add die for all local test scripts [please reassign] Jun 10, 2022

arkamar changed the title ~~dev-db/redis: add die for all local test scripts [please reassign]~~ dev-db/redis: rework src_test [please reassign] Jun 10, 2022

arkamar force-pushed the redis branch from b6c9740 to 8971f91 Compare June 10, 2022 20:47

gentoo-bot changed the title ~~dev-db/redis: rework src_test [please reassign]~~ dev-db/redis: rework src_test Jun 10, 2022

gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jun 10, 2022

thesamesam reviewed Jun 10, 2022

View reviewed changes

arkamar added 6 commits June 11, 2022 22:12

dev-db/redis: use edo function for all local test scripts

f1f8107

Signed-off-by: Petr Vaněk <arkamar@atlas.cz>

dev-db/redis: limit a number of test clients to MAKEOPTS jobs

6dc99c3

It is necessary to cal ./runtest directly from src_test function in order to be able to pass --clients parameter. Bug: https://bugs.gentoo.org/649868 Signed-off-by: Petr Vaněk <arkamar@atlas.cz>

dev-db/redis: limit a number of test clients to MAKEOPTS jobs

790b62f

This change makes tests to respect user MAKEOPTS jobs preference rather than running 16 test clients by default. Closes: https://bugs.gentoo.org/649868 Signed-off-by: Petr Vaněk <arkamar@atlas.cz>

dev-db/redis: restore defrag tests on 6.2* and 7.0*

b325b5d

Defrag tests with enabled jemalloc are fixed since version 6.2*, let's restore them back. Signed-off-by: Petr Vaněk <arkamar@atlas.cz>

arkamar force-pushed the redis branch from 8971f91 to 5b0c6a3 Compare June 11, 2022 20:48

arkamar requested a review from thesamesam June 12, 2022 16:04

gentoo-bot closed this in 6869d1a Jun 12, 2022

thesamesam reopened this Jun 12, 2022

thesamesam closed this Jun 12, 2022

arkamar deleted the redis branch June 13, 2022 06:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dev-db/redis: rework src_test #25831

dev-db/redis: rework src_test #25831

arkamar commented Jun 9, 2022

gentoo-repo-qa-bot commented Jun 9, 2022

arkamar commented Jun 9, 2022

arkamar commented Jun 10, 2022

gentoo-bot commented Jun 10, 2022

gentoo-repo-qa-bot commented Jun 10, 2022

gentoo-repo-qa-bot commented Jun 10, 2022

thesamesam Jun 10, 2022

arkamar Jun 11, 2022

thesamesam Jun 10, 2022

arkamar Jun 11, 2022

thesamesam Jun 12, 2022

gentoo-repo-qa-bot commented Jun 11, 2022

arkamar commented Jun 11, 2022

thesamesam commented Jun 12, 2022

thesamesam commented Jun 13, 2022

dev-db/redis: rework src_test #25831

dev-db/redis: rework src_test #25831

Conversation

arkamar commented Jun 9, 2022

gentoo-repo-qa-bot commented Jun 9, 2022

Pull request CI report

arkamar commented Jun 9, 2022

arkamar commented Jun 10, 2022

gentoo-bot commented Jun 10, 2022

Pull Request assignment

Linked bugs

gentoo-repo-qa-bot commented Jun 10, 2022

Pull request CI report

gentoo-repo-qa-bot commented Jun 10, 2022

Pull request CI report

thesamesam Jun 10, 2022

Choose a reason for hiding this comment

arkamar Jun 11, 2022

Choose a reason for hiding this comment

thesamesam Jun 10, 2022

Choose a reason for hiding this comment

arkamar Jun 11, 2022

Choose a reason for hiding this comment

thesamesam Jun 12, 2022

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Jun 11, 2022

Pull request CI report

arkamar commented Jun 11, 2022

thesamesam commented Jun 12, 2022

thesamesam commented Jun 13, 2022