app-admin/filebeat: new package #2585
Conversation
Filebeat is part of the Beats family by Elasticsearch. It's a lightweight log forwarder to Logstash & Elasticsearch. We already have a binary version of the package in tree, but this non-binary should eventually remove it. Package-Manager: portage-2.3.1
|
@gentoo/proxy-maint |
gktrk
added
bugfix
new package
| S="${BEATS}" | ||
|
|
||
| src_unpack() { | ||
| mkdir -p "${ELASTIC}" |
| src_unpack() { | ||
| mkdir -p "${ELASTIC}" | ||
| unpack ${P}.tar.gz | ||
| mv beats-${PV} "${BEATS}" |
| } | ||
|
|
||
| src_compile() { | ||
| export GOPATH="${WORKDIR}" |
There was a problem hiding this comment.
Nope. Instead, you should be doing:
cd ${BEATS}/filebeat || die
GOPATH="${WORKDIR}" emake
| } | ||
|
|
||
| checkconfig() { | ||
| if [ ! -e ${FILEBEAT_CONFIG} ]; then |
There was a problem hiding this comment.
Use [[ and ]] for consistency.
| @@ -0,0 +1,5 @@ | |||
| #FILEBEAT_USER="" | |||
There was a problem hiding this comment.
If this is meant to be configured by the user, adding some documentation and explaining what these variables are about would be useful.
| SLOT="0" | ||
| KEYWORDS="~amd64" | ||
|
|
||
| DEPEND="dev-lang/go" |
There was a problem hiding this comment.
Also, since there's already a binary version in the tree, installing both versions should be somehow forbidden. Make sure to add !app-admin/filebeat-bin to DEPEND.
|
Thank you very much @monsieurp for the review. |
Package-Manager: portage-2.3.1
|
😞 The QA check for this pull request has found the following issues: Issues inherited from Gentoo (may be modified by PR): |
Filebeat is part of the Beats family by Elasticsearch. It's a
lightweight log forwarder to Logstash & Elasticsearch.
We already have a binary version of the package in tree,
but this non-binary should eventually remove it.
Package-Manager: portage-2.3.1