dev-libs/libflatarray: version bump to 0.3.0 #2607
Conversation
This adds an ebuild for LibFlatArray 0.3.0, which was releasd here: http://libgeodecomp.org/news_libflatarray_030.html Package-Manager: portage-2.3.2
| # Distributed under the terms of the GNU General Public License v2 | ||
| # $Id$ | ||
|
|
||
| EAPI=5 |
| LICENSE="Boost-1.0" | ||
| IUSE="cuda doc" | ||
|
|
||
| DEPEND="${RDEPEND} |
There was a problem hiding this comment.
why include RDEPEND if it's empty?
| if use cuda; then | ||
| cuda_src_prepare | ||
| fi | ||
| } |
There was a problem hiding this comment.
turn this into:
src_prepare() {
use cuda && cuda_src_prepare
cmake-utils_src_prepare
}
|
|
||
| src_configure() { | ||
| local mycmakeargs=( | ||
| $(cmake-utils_use_with cuda CUDA) -DWITH_SILO=false |
There was a problem hiding this comment.
you'll have to get rid of the cmake-utils functions for EAPI=6, also put the -DWITH_SILO on a separate line
|
|
||
| src_compile() { | ||
| cmake-utils_src_compile | ||
| } |
There was a problem hiding this comment.
not needed, EXPORT_FUNCTIONS'd by the eclass
| src_install() { | ||
| DOCS=( README ) | ||
| cmake-utils_src_install | ||
| } |
There was a problem hiding this comment.
not needed, EXPORT_FUNCTIONS'd by the eclass
|
|
||
| src_test() { | ||
| cmake-utils_src_make test | ||
| } |
There was a problem hiding this comment.
not needed, EXPORT_FUNCTIONS'd by the eclass
Package-Manager: portage-2.3.2
|
@SoapGentoo Thanks for the feedback. I make the changes you requested, please review. :-) |
|
@SoapGentoo ping |
|
|
||
| DEPEND=" | ||
| doc? ( app-doc/doxygen ) | ||
| cuda? ( dev-util/nvidia-cuda-toolkit )" |
There was a problem hiding this comment.
you sure cuda is only a build-time dependency? @marbre I don't use CUDA, could you please give your input here?
There was a problem hiding this comment.
Yes, this is valid.
In the case of LibFlatArray enabling the CUDA build option obviously requires the CUDA toolkit to be installed. If CUDA gets removed after the installation of LibFlatArray, the library stays in a usable state. Its CUDA components only get activated if someone's using NVCC (from the CUDA Toolkit) to compile source.
There was a problem hiding this comment.
@gentryx It seems it is a header only library since no binaries are compiled that are linked against e.g. cufft., right?
@SoapGentoo Thus the library itself has no run time dependencies, as it cannot be executed, but the applications using the cuda specific includes of libflatarray have.
And please excuse the late reply.
There was a problem hiding this comment.
@mabre: yeah, that's right.
|
|
||
| src_prepare() { | ||
| use cuda && cuda_src_prepare | ||
| cmake-utils_src_prepare |
There was a problem hiding this comment.
also, one more small request, could you please swap these? applying patches is the first thing that should happen in src_prepare
There was a problem hiding this comment.
thanks. makes sense. done.
Package-Manager: portage-2.3.2
|
@gentryx one last thing: can you please squash all your commits into one? Have a look here: https://wiki.gentoo.org/wiki/Gentoo_Github#Rebasing_commits |
This adds an ebuild for LibFlatArray 0.3.0, which was released here:
http://libgeodecomp.org/news_libflatarray_030.html
Package-Manager: portage-2.3.2