Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gui-wm/wayfire: bump to 0.7.3 #26087

Closed
wants to merge 2 commits into from
Closed

gui-wm/wayfire: bump to 0.7.3 #26087

wants to merge 2 commits into from

Conversation

m1027
Copy link
Contributor

@m1027 m1027 commented Jun 26, 2022 •
edited

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Jun 26, 2022
@m1027 m1027 changed the title gui-wm/wayfire: bump to 0.7.3 gui-wm/wayfire: bump to 0.7.3 [please reassign] Jun 26, 2022
@gentoo-bot gentoo-bot changed the title gui-wm/wayfire: bump to 0.7.3 [please reassign] gui-wm/wayfire: bump to 0.7.3 Jun 26, 2022
@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. and removed assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Jun 26, 2022
@m1027 m1027 changed the title gui-wm/wayfire: bump to 0.7.3 gui-wm/wayfire: bump to 0.7.3 [please reassign] Jun 26, 2022
@gentoo-bot gentoo-bot changed the title gui-wm/wayfire: bump to 0.7.3 [please reassign] gui-wm/wayfire: bump to 0.7.3 Jun 26, 2022
@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. and removed assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits. no signoff One or more commits do not indicate GCO sign-off. labels Jun 26, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-06-26 21:49 UTC
Newest commit scanned: 6ec9a9f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ebbe298032/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-06-26 22:09 UTC
Newest commit scanned: d85dabe
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e014346efd/output.html

@m1027 m1027 changed the title gui-wm/wayfire: bump to 0.7.3 gui-wm/wayfire: bump to 0.7.3 [please reassign] Jun 27, 2022
@gentoo-bot gentoo-bot changed the title gui-wm/wayfire: bump to 0.7.3 [please reassign] gui-wm/wayfire: bump to 0.7.3 Jun 27, 2022
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @m1027
Areas affected: ebuilds
Packages affected: gui-wm/wayfire

gui-wm/wayfire: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 840978

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits. labels Jun 27, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-06-27 06:09 UTC
Newest commit scanned: 79a8c37
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/cb5809e20c/output.html

juippis
juippis reviewed Jul 5, 2022
View reviewed changes
gui-wm/wayfire/wayfire-0.7.3.ebuild Outdated
Comment on lines 49 to 50
>=gui-libs/wlroots-0.15.0:=[X?]
<gui-libs/wlroots-0.16.0:=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this'd be simpler if you just dependend on the subslot?

Suggested change
>=gui-libs/wlroots-0.15.0:=[X?]
<gui-libs/wlroots-0.16.0:=
gui-libs/wlroots:0/15

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, applied, readding [X?] though.

gui-wm/wayfire/wayfire-0.7.3.ebuild
Comment on lines +39 to +42
X? (
x11-base/xwayland
x11-libs/libxcb
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

meson.build:141:2: ERROR: Problem encountered: Cannot enable Xwayland in wayfire: wlroots has been built without Xwayland support

[ERROR] >>> Not all runs were successful.
atom: =gui-wm/wayfire-0.7.3, USE flags: 'X -gles -system-wfconfig system-wlroots'
atom: =gui-wm/wayfire-0.7.3, USE flags: 'X -gles system-wfconfig -system-wlroots'
atom: =gui-wm/wayfire-0.7.3, USE flags: 'X -gles system-wfconfig system-wlroots'

So +X seems to fail, apparently to a missing dependency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did more USE on/off tests, after all applying suggestions and changes. +X works now.

gui-wm/wayfire/wayfire-0.7.3.ebuild Outdated
Comment on lines 24 to 25
dev-libs/libevdev
dev-libs/libinput
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are both of these required, aren't these supposed to replace each other?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't aware, thanks. libevdev removed.

gui-wm/wayfire/wayfire-0.7.3.ebuild Outdated
Comment on lines 24 to 25
dev-libs/libevdev
dev-libs/libinput
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dev-libs/libevdev
dev-libs/libinput
dev-libs/libinput:=

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied.

gui-wm/wayfire/wayfire-0.7.3.ebuild Outdated
media-libs/glm
media-libs/mesa:=[gles2,wayland,X?]
media-libs/libglvnd[X?]
media-libs/libjpeg-turbo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
media-libs/libjpeg-turbo
media-libs/libjpeg-turbo:=

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied.

gui-wm/wayfire/wayfire-0.7.3.ebuild Outdated
media-libs/mesa:=[gles2,wayland,X?]
media-libs/libglvnd[X?]
media-libs/libjpeg-turbo
media-libs/libpng
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
media-libs/libpng
media-libs/libpng:=

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied.

gui-wm/wayfire/wayfire-0.7.3.ebuild Outdated
media-libs/freetype:=[X?]
x11-libs/libdrm
x11-libs/gtk+:3=[wayland,X?]
x11-libs/cairo:=[X?,svg]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
x11-libs/cairo:=[X?,svg]
x11-libs/cairo[X?,svg]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied

gui-wm/wayfire/wayfire-0.7.3.ebuild Outdated
x11-libs/libdrm
x11-libs/gtk+:3=[wayland,X?]
x11-libs/cairo:=[X?,svg]
x11-libs/libxkbcommon:=[X?]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
x11-libs/libxkbcommon:=[X?]
x11-libs/libxkbcommon[X?]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied.

gui-wm/wayfire/wayfire-0.7.3.ebuild Outdated
Comment on lines 37 to 38
x11-libs/libxkbcommon:=[X?]
x11-libs/pixman
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
x11-libs/libxkbcommon:=[X?]
x11-libs/pixman
x11-libs/libxkbcommon[X?]
x11-libs/pango
x11-libs/pixman

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied.

m1027 added 2 commits July 8, 2022 10:21
@m1027
gui-wm/wayfire: bump to 0.7.3
33f9e2d 
Closes: https://bugs.gentoo.org/840978
Signed-off-by: Marc Cramer <m1027@posteo.net>
@m1027
gui-wm/wayfire: bump to 0.7.3, deps fixed
edbfb5d 
Closes: https://bugs.gentoo.org/840978
Signed-off-by: Marc Cramer <m1027@posteo.net>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-07-08 08:44 UTC
Newest commit scanned: edbfb5d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/75f57a9681/output.html

@m1027
Copy link
Contributor Author

m1027 commented Jul 8, 2022

So, thanks for the help with this ebuild and the nice explanatory suggestions.

To have lssens learned I generalized your suggestens a bit and come up with a couple of questions (sightly OT). Just in case you find time to answer on that...:

(1) You suggested to add/remove ":=" for slots. Is that manual work for devs, I mean, that you check every dependency whether there are slots or not?

(2) Avoiding alternative libraries as deps (libevdev, libinput): This is probably only feasible with some experience I guess.

(3) Missing deps: You added e.g. pango, right. As this had been obviously present already on my box, how would I do a proper dependency check when working on ebuilds...

(4) USE flag on/off testing. I did that manually for now and this is a bit error prone, too, as adding +X might trigger other packages +X and one has to remove that from those deps afterwards carefully again to do proper tests... I wonder whether there is a better way to do these USE on/off build tests.

Thanks again

@thesamesam
Copy link
Member

So, thanks for the help with this ebuild and the nice explanatory suggestions.

To have lssens learned I generalized your suggestens a bit and come up with a couple of questions (sightly OT). Just in case you find time to answer on that...:

(1) You suggested to add/remove ":=" for slots. Is that manual work for devs, I mean, that you check every dependency whether there are slots or not?

iwdevtools can help show you this!

(2) Avoiding alternative libraries as deps (libevdev, libinput): This is probably only feasible with some experience I guess.

(3) Missing deps: You added e.g. pango, right. As this had been obviously present already on my box, how would I do a proper dependency check when working on ebuilds...

iwdevtools again :)

(4) USE flag on/off testing. I did that manually for now and this is a bit error prone, too, as adding +X might trigger other packages +X and one has to remove that from those deps afterwards carefully again to do proper tests... I wonder whether there is a better way to do these USE on/off build tests.

juippis uses https://wiki.gentoo.org/wiki/User:Juippis/The_ultimate_testing_system_with_lxd but see also https://wiki.gentoo.org/wiki/Package_testing. Lots of other tools out there: https://wiki.gen.

Thanks again

@thesamesam
Copy link
Member

Could you as a follow up PR sync the live ebuild? Ideally use a template (if [[ ${PV} == 9999 ]] ..., like other ebuilds often do) to make it easier to keep in sync?

@thesamesam
Copy link
Member

thesamesam commented Jul 10, 2022 •
edited

Merged (squashed) as 043e5f8, thanks!

@thesamesam thesamesam closed this Jul 10, 2022
@m1027 m1027 deleted the wayfire-0.7.3 branch July 11, 2022 19:40
@m1027
Copy link
Contributor Author

m1027 commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
5 participants
@m1027 @gentoo-repo-qa-bot @gentoo-bot @thesamesam @juippis