Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-libs/intel-compute-runtime: add patch to remove -D_FORTIFY_SOURCE=2 configuration from build process #26119

Closed
wants to merge 1 commit into from
Closed

dev-libs/intel-compute-runtime: add patch to remove -D_FORTIFY_SOURCE=2 configuration from build process #26119

wants to merge 1 commit into from

Conversation

ran-dall
Copy link
Contributor

Signed-off-by: Randall T. Vasquez ran.dall@icloud.com

@ran-dall
Copy link
Contributor Author

ping @thesamesam

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @ran-dall
Areas affected: ebuilds
Packages affected: dev-libs/intel-compute-runtime

dev-libs/intel-compute-runtime: @janhenke, @gentoo/proxy-maint, @ConiKost

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jun 28, 2022
@ConiKost
Copy link
Contributor

Can't be this done with sed instead using a patch for it?

@ran-dall
Copy link
Contributor Author

@ConiKost It could, but we decided to get rid of the whole line so I think we decided on a patch, but honestly either way is good with me.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-06-28 17:44 UTC
Newest commit scanned: ccca298
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/99423a21b8/output.html

@ran-dall
dev-libs/intel-compute-runtime: add patch to remove `-D_FORTIFY_SOURC…
bfd9bff 
…E=2` configuration from build process

Signed-off-by: Randall T. Vasquez <ran.dall@icloud.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-06-28 19:49 UTC
Newest commit scanned: bfd9bff
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/29b61c6d6d/output.html

ConiKost
ConiKost approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@ConiKost ConiKost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Just a small nit pick: I added ${PN}-${PV} to patch name and updated ebuild. Otherwise merged as it is.

@ran-dall ran-dall deleted the fix/intel-compute-runtime branch June 28, 2022 20:09
@ran-dall
Copy link
Contributor Author

Thank you @ConiKost 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConiKost ConiKost ConiKost approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
4 participants
@ran-dall @gentoo-bot @ConiKost @gentoo-repo-qa-bot