app-emulation/virtualbox-modules: fix kernel >= 5.18 build fail

[peeweep]

Closes: https://bugs.gentoo.org/847094

Signed-off-by: peeweep peeweep@0x0.ee

[gentoo-bot]

Pull Request assignment

Submitter: @peeweep
Areas affected: ebuilds
Packages affected: app-emulation/virtualbox-modules

app-emulation/virtualbox-modules: polynomial-c

At least one of the listed packages is maintained entirely by non-GitHub developers!

Linked bugs

Bugs linked: 847094

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[Tatsh]

The patch already has kernel version checks. Checking in the ebuild is not necessary.

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2022-06-28 22:39 UTC
Newest commit scanned: 4d2f3e1
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c924105957/output.html

[aristocrates]

In https://www.virtualbox.org/ticket/20914 there is a patch [1] that includes a number of changes beyond what is in this PR - should the patch include the other relevant changes? Another example: the opensuse patch [2]

[1] https://www.virtualbox.org/raw-attachment/ticket/20914/vbox-linux-5.18.patch

• Note that some of the files modified in that patch are not present when vbox-kernel-module-src-${PV}.tar.gz is extracted, and others appear to have different full paths in the source tree

[2] https://build.opensuse.org/package/view_file/Virtualization/virtualbox/fixes_for_kernel_5.18.patch?expand=1

[peeweep]

@aristocrates Thank you for providing information, I haven't seen this ticket before. I'm not sure about the influence of vbox-linux-5.18.patch (except for fixing the compile problem, I can understand this). I think this PR is best used to fix compile error. Do not introduce other problems.

[ignamartinoli]

Will this change target kernel 5.18.9? It would be awesome

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2022-07-10 13:49 UTC
Newest commit scanned: f44ca2e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/86fc1dec23/output.html

[M1cR0xf7]

any updates? is this going to get merged

[xfzv]

any updates? is this going to get merged

VirtualBox 6.1.36 was released on July 19th

From changelog:

- Linux Host and Guest drivers: Introduced initial support for kernels 5.18, 5.19 and RHEL 9.1 (bugs [#20914](https://www.virtualbox.org/ticket/20914), [#20941](https://www.virtualbox.org/ticket/20941))

So I guess the patch won't be required anymore?

[ignamartinoli]

@xfzv so we should just upsource VirtualBox?

[xfzv]

@xfzv so we should just upsource VirtualBox?

Arch Linux maintainer deleted the patch (click on Load diff on trunk/020-linux518.patch to see relevant lines) when updating PKGBUILD to 6.1.36, that's why I assume it will no longer be required on Gentoo either.

[peeweep]

I think the bug can be closed when Gentoo's virtualbox is upgraded to 6.1.36

[ignamartinoli]

@peeweep agreed, is there a way to ask for this to the maintainers?

[thesamesam]

Obsolete given bump is done. Thanks!