media-plugins/gst-transcoder: Fix libdir for meson build #2624
Conversation
|
Some justification for the package versions in this PR: If someone has already successfully built pitivi-0.97.1 there should be no need for a rebuild even if the gst-transcoder as a dependency gets upgraded from 1.8.[12] to 1.8.2-r1, so there's no revbump needed there. A successful build indicates that the existing gst-transcoder was already correctly installed. For gst-transcoder-1.8.2 alone, there's no guarantee that the installed files are at the correct location so a revbump is needed to ensure this. |
|
|
||
| LICENSE="GPL-2" | ||
| SLOT="0" | ||
| KEYWORDS="amd64 x86" |
There was a problem hiding this comment.
don't commit ebuilds with stable KEYWORDS
|
@jok-ts please squash the last commit into your main edit, as 1) it doesn't have the right COMMITMSG and 2) doesn't need to live on its own |
monsieurp
added
bugfix
assigned
|
Looks like fine work, 👍 to merge. |
| # Not a normal configure | ||
| # --buildtype=plain needed for honoring CFLAGS/CXXFLAGS and not | ||
| # defaulting to debug | ||
| ./configure --prefix=/usr --libdir="$(get_libdir)" --buildtype=plain || die |
There was a problem hiding this comment.
could you make --prefix="${EPREFIX}/usr" instead? We should always aim for Prefix-awareness
There was a problem hiding this comment.
Sure. This is something to raise in bug 597182 as well.
| @@ -82,6 +82,7 @@ src_configure() { | |||
| ./configure \ | |||
| --prefix=/usr \ | |||
Gentoo-Bug: 591564
Gentoo-Bug: 597414
Gentoo-Bug: https://bugs.gento.org/597414 Closes: #2624 Signed-off-by: Patrice Clement <monsieurp@gentoo.org>
dev-util/meson guesses libdir for the build incorrectly if /usr/bin/dpkg-architecture exists, see
Gentoo-Bug: 591564
Use the known correct value for Gentoo instead of the default guess.