Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-cluster/hpx: Fix building on musl #26281

Closed
wants to merge 1 commit into from
Closed

sys-cluster/hpx: Fix building on musl #26281

wants to merge 1 commit into from

Conversation

listout
Copy link
Contributor

@listout listout commented Jul 8, 2022

These patches fixes building on musl. I've tried to document the patches
to the best of my abilities.

Mainly fixes the RTLD_DI_ORIGIN not being present in musl.

Closes: https://bugs.gentoo.org/829242

Signed-off-by: brahmajit das brahmajit.xyz@gmail.com

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @listout
Areas affected: ebuilds
Packages affected: sys-cluster/hpx

sys-cluster/hpx: @shifty91, @gentoo/proxy-maint

Linked bugs

Bugs linked: 829242

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jul 8, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-07-08 12:19 UTC
Newest commit scanned: 7edc981
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b7bf9007bc/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-07-08 18:09 UTC
Newest commit scanned: 5d4b735
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/16b07b7a9d/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-07-08 19:59 UTC
Newest commit scanned: 9cb9f53
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c159ab6abd/output.html

thesamesam
thesamesam reviewed Jul 9, 2022
View reviewed changes
Copy link
Member

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. It looks like you even landed them upstream! Please add a link to the upstream commits at the top of each patch. Then I'm very happy!

@listout
sys-cluster/hpx: Fix building on musl
f11dced 
These patches fixes building on musl. I've tried to document the patches
to the best of my abilities.

Mainly fixes the RTLD_DI_ORIGIN not being present in musl.

However with this PR [1] we won't be requiring these patches anymore
from 1.8.1

[1]: STEllAR-GROUP/hpx#5947

Closes: https://bugs.gentoo.org/829242

Signed-off-by: brahmajit das <brahmajit.xyz@gmail.com>
@listout
Copy link
Contributor Author

listout commented Jul 9, 2022

This looks great to me. It looks like you even landed them upstream! Please add a link to the upstream commits at the top of each patch. Then I'm very happy!

Done

@listout listout requested a review from thesamesam July 9, 2022 04:43
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-07-09 04:54 UTC
Newest commit scanned: f11dced
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6abbcbe596/output.html

@gentoo-bot gentoo-bot closed this in 5ca83cb Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesamesam thesamesam Awaiting requested review from thesamesam

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@listout @gentoo-bot @gentoo-repo-qa-bot @thesamesam