Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distutils-r1.eclass: support >=dev-util/maturin-0.13.0 #26317

Closed
wants to merge 3 commits into from
Closed

distutils-r1.eclass: support >=dev-util/maturin-0.13.0 #26317

wants to merge 3 commits into from

Conversation

ionenwks
Copy link
Contributor

@gentoo/python please ack for distutils-r1.eclass changes (see commit message for details), feels rather local/simple (2 revdeps) so won't bother sending to ML unless want that anyway.

If want to confirm passed args, there is a Running 'maturin ... --compatibility off <eclass-args>' line in adblock/watchfiles build.log.

On a side-note, most maturin pyproject.toml have a <0.13 but it doesn't stop use of 0.13 and I know of no issues at the moment.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @ionenwks
Areas affected: ebuilds, eclasses
Packages affected: dev-util/maturin

dev-util/maturin: @ionenwks, @steils, @gentoo/rust

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Jul 10, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-07-10 02:44 UTC
Newest commit scanned: 2ecbf96
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/dbeee9b6bd/output.html

mgorny
mgorny reviewed Jul 10, 2022
View reviewed changes
eclass/distutils-r1.eclass Outdated Show resolved Hide resolved
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-07-10 07:44 UTC
Newest commit scanned: f87adb8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/89184d60a0/output.html

@mgorny
Copy link
Member

mgorny commented Jul 11, 2022

@ionenwks, could you add the ebegin patch (v2) from gentoo-dev on top of it? Feel free to merge afterwards.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-07-11 16:05 UTC
Newest commit scanned: b4b57fc
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/deaf06b9e6/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-07-11 20:19 UTC
Newest commit scanned: 3c834e2
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3d7fa627c8/output.html

@mgorny
Copy link
Member

mgorny commented Jul 12, 2022

Could you also bump Python 3.11 dep to beta4 in python-utils-r1?

@ionenwks
distutils-r1.eclass: support >=dev-util/maturin-0.13.0
ba025d7 
pep517 mode had some options changed around (as part of 1.0
release roadmap), notably adds --jobs/--profile, and removes
--cargo-extra-args.

--jobs is semi-optional given cargo.eclass handles that, but will
be useful in the event don't use cargo.eclass (e.g. vendored crates),
or if maturin ever uses it internally for non-cargo bits.

Errors out on unrecognized options, so split in two blocks with intend
to cleanup the old once a 0.13.x is stable rather than do messy
per-option conditions (likely won't stable .0, releases are frequent).

Signed-off-by: Ionen Wolkens <ionen@gentoo.org>
@ionenwks
dev-util/maturin: add 0.13.0
b5f7e2b 
Drop "-i","python" sed for tests, upstream no longer tries to
auto-detect and now does this by default.

Signed-off-by: Ionen Wolkens <ionen@gentoo.org>
@ionenwks
python-utils-r1.eclass: bump minimum 3.11 dep to 3.11.0_beta4
f8645ed 
Signed-off-by: Ionen Wolkens <ionen@gentoo.org>
@ionenwks
Copy link
Contributor Author

Could you also bump Python 3.11 dep to beta4 in python-utils-r1?

done, let me know if still want ML's check_deps using v3 or just leave it as ebegin/end

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-07-12 10:20 UTC
Newest commit scanned: f8645ed
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/aae7f46abe/output.html

@mgorny
Copy link
Member

mgorny commented Jul 12, 2022

Let's leave it as-is for now. We can revisit when we're removing old maturin support.

@ionenwks
Copy link
Contributor Author

Guess nothing else to do here then, merging.

@ionenwks ionenwks deleted the maturin013 branch July 12, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny left review comments

@thesamesam thesamesam thesamesam approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
5 participants
@ionenwks @gentoo-bot @gentoo-repo-qa-bot @mgorny @thesamesam