Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxde-base/lxappearance-obconf: Fix slibtool build #26358

Closed
wants to merge 1 commit into from
Closed

lxde-base/lxappearance-obconf: Fix slibtool build #26358

wants to merge 1 commit into from

Conversation

orbea
Copy link
Contributor

@orbea orbea commented Jul 12, 2022

Also fixes a -Wimplicit-function-declaration for cairo_xlib_surface_create.

Bug: https://bugs.gentoo.org/779484

@orbea
lxde-base/lxappearance-obconf: Fix slibtool build
000b24a 
Also fixes a -Wimplicit-function-declaration for cairo_xlib_surface_create.

Bug: https://bugs.gentoo.org/779484
Signed-off-by: orbea <orbea@riseup.net>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @orbea
Areas affected: ebuilds
Packages affected: lxde-base/lxappearance-obconf

lxde-base/lxappearance-obconf: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 779484

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jul 12, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-07-12 01:09 UTC
Newest commit scanned: 000b24a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/fa417020ab/output.html

@thesamesam
Copy link
Member

Did you include the implicit decl. fix?

src/preview.c:146:15: error: implicit declaration of function 'cairo_xlib_surface_create'; did you mean 'cairo_image_surface_create'? [-Werror=implicit-function-declaration]
  146 |     surface = cairo_xlib_surface_create(dpy,
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~
      |               cairo_image_surface_create

@orbea
Copy link
Contributor Author

orbea commented Jul 12, 2022 •
edited

See the second patch.

000b24a#diff-19e38d3579350e26f807ca2c93a93428cf31881cb76518596972372f5b214be9

Edit: I was wrong and this was fixed in PR #26359. (For future reference)

@orbea orbea deleted the lxde branch July 12, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
4 participants
@orbea @gentoo-bot @gentoo-repo-qa-bot @thesamesam