Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-lang/erlang: fix localhost clash with Docker #26360

Closed
wants to merge 1 commit into from
Closed

dev-lang/erlang: fix localhost clash with Docker #26360

wants to merge 1 commit into from

Conversation

ignamartinoli
Copy link
Contributor

need is incompatible with Docker

Closes: https://bugs.gentoo.org/857099
Signed-off-by: igna_martinoli ignamartinoli@protonmail.com

need is incompatible with Docker

Closes: https://bugs.gentoo.org/857099
Signed-off-by: igna_martinoli <ignamartinoli@protonmail.com>
ignamartinoli referenced this pull request Jul 12, 2022
net.lo is netifrc specific.

Closes: https://bugs.gentoo.org/857099
Closes: #26303
Signed-off-by: igna_martinoli <ignamartinoli@protonmail.com>
Signed-off-by: Sam James <sam@gentoo.org>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @ignamartinoli
Areas affected: ebuilds
Packages affected: dev-lang/erlang

dev-lang/erlang: @jpds, @MatthewGentoo

Linked bugs

Bugs linked: 857099


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jul 12, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-07-12 03:59 UTC
Newest commit scanned: 4e57201
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/745e4f891d/output.html

@thesamesam
Copy link
Member

@tgbugs ok?

@tgbugs
Copy link
Contributor

tgbugs commented Jul 12, 2022

Hrm. In my testing this fails to start. Debugging now.

@tgbugs
Copy link
Contributor

tgbugs commented Jul 12, 2022

In summary: yes, this fixes the issue. Other issues seem to be related to the default conf.d file.

Ok, so there is some really broken stuff going on between rabbitmq and epmd. This does indeed resolve my immediate issue with docker ... but only because epmd is technically "running" when it is in the crashed state and rabbitmq then seemingly starts its own instance of epmd (!?!?!). It looks like epmd crashes in docker no matter what right now. I did my test with loopback down/disabled, and everything seems ok with use loopback. edit: Not only that ... but the empd that is started by rabbitmq runs under the rabbitmq users but can be stopped by running /etc/init.d/epmd stop. I'm guessing this is due to /run not being mounted or something crazy like that.

All in all I think this is ok, and more representative of correct epmd behavior. The epmd init in docker is still borked, but let's take that in a separate issue.

edit2: in the container it seems that what is happening is that it can't bind on 127.0.0.1

epmd -address 127.0.0.1
epmd: Tue Jul 12 04:42:25 2022: failed to bind on ipaddr 127.0.0.1: Address not available

I suspect that I should remove the command args from conf.d in this case an it will work as expected.

@tgbugs
Copy link
Contributor

tgbugs commented Jul 12, 2022

On further though, why not just comment out the command_args line in conf.d while we're at it since that is technically the default behavior anyway?

@MatthewGentoo
Copy link
Member

Would it be best to have use net instead of use lo for cases like this where the bind address is changed?

@ignamartinoli
Copy link
Contributor Author

Hey, sorry for going missing. I was submerged by university and planned to resume the work with this on November.

Thanks @MatthewGentoo for giving this issue a conclusion, I really hope to be able to help on other issues soon 😃

@ignamartinoli ignamartinoli deleted the fix-epmd-docker branch October 16, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
6 participants