www-servers/nginx: add modsecurity v3 support #26401
Conversation
Pull Request assignmentSubmitter: @hydrapolic dev-libs/modsecurity: @gentoo/proxy-maint (new package) Linked bugsNew packagesThis Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
new package
Pull request CI reportReport generated at: 2022-07-14 12:49 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
hydrapolic
changed the title
hydrapolic
changed the title
Pull request CI reportReport generated at: 2022-07-14 17:54 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| lua? ( ${LUA_DEPS} ) | ||
| pcre2? ( dev-libs/libpcre2:= )" | ||
| DEPEND="${COMMON_DEPEND} | ||
| doc? ( app-doc/doxygen[dot] )" |
There was a problem hiding this comment.
Doxygen should be BDEPEND.
| BDEPEND="virtual/pkgconfig" | ||
|
|
||
| DOCS=( AUTHORS CHANGES README.md modsecurity.conf-recommended unicode.mapping ) | ||
| S="${WORKDIR}/${MY_P}" |
There was a problem hiding this comment.
S please after SRC_URI. See skel.ebuild.
| default | ||
|
|
||
| if use doc; then | ||
| dodoc -r doc/html |
There was a problem hiding this comment.
This could be a oneliner? use doc && ..
| dodoc -r doc/html | ||
| fi | ||
|
|
||
| rm "${ED}/usr/$(get_libdir)/libmodsecurity.la" || die |
There was a problem hiding this comment.
I would prefer the generic one find "${ED}" -name '*.la' -delete || die, which most ebuilds use.
Modsecurity is a library that can be used by Nginx: https://github.com/SpiderLabs/ModSecurity-nginx For Apache, Modsecurity 2.x is still recommended. Bug: https://bugs.gentoo.org/726614 Closes: https://bugs.gentoo.org/718358 Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>
Closes: https://bugs.gentoo.org/726614 Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>
Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>
Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>
|
Thanks for the review @ConiKost, pushed an update. |
Pull request CI reportReport generated at: 2022-07-19 12:11 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Thank you @ConiKost |
Legacy modsecurity v2 was removed in #26347 as it failed to build due to nginx 1.23.0 api changes, this adds modsecurity v3 with nginx connector.
Tested on ~amd64, thanks.