dev-lisp/c2ffi: Bump version to c2ffi-13.0.0 (bug #840610) #26464
Conversation
Pull Request assignmentSubmitter: @hjudt dev-lisp/c2ffi: @hjudt, @gentoo/proxy-maint Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. Missing GCO sign-offPlease read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
self-maintained
Pull request CI reportReport generated at: 2022-07-18 14:14 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2022-07-18 14:29 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| @@ -16,9 +16,7 @@ SLOT="0" | |||
| KEYWORDS="~amd64" | |||
| IUSE="" | |||
| @@ -1,11 +1,11 @@ | |||
| # Copyright 2019-2021 Gentoo Authors | |||
| # Copyright 2019-2022 Gentoo Authors | |||
| # Distributed under the terms of the GNU General Public License v2 | |||
|
|
|||
| EAPI=7 | |||
| DEPEND="sys-devel/clang:12= | ||
| sys-devel/llvm:12= | ||
| " | ||
| DEPEND="sys-devel/clang:13=" | ||
| RDEPEND="${DEPEND}" | ||
|
|
||
| S="${WORKDIR}/c2ffi-${MY_COMMIT}" |
There was a problem hiding this comment.
S after SRC_URI please. See skel.ebuild.
There was a problem hiding this comment.
Also fixed, should be in the right order now.
Pull request CI reportReport generated at: 2022-07-18 14:59 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
|
||
| inherit cmake llvm | ||
|
|
||
| MY_COMMIT="3a92064409d258e1688727266c3f023a502e8866" | ||
| MY_COMMIT="bfa50485ffa86b886215c72ea1e43dbd3acaf940" | ||
|
|
||
| DESCRIPTION="Clang-based FFI wrapper generator for Common Lisp" | ||
| HOMEPAGE="https://github.com/rpav/c2ffi" | ||
| SRC_URI="https://github.com/rpav/c2ffi/archive/${MY_COMMIT}.tar.gz -> ${P}.tar.gz" | ||
|
|
Closes: https://bugs.gentoo.org/840610 Signed-off-by: Harald Judt <h.judt@gmx.at>
Signed-off-by: Harald Judt <h.judt@gmx.at>
Pull request CI reportReport generated at: 2022-07-18 18:06 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
Actually, there is one more problem. You named your ebuild c2ffi-13.0.0.20220626.ebuild, while I guess, this is a pre-release? If so, than this is a bad idea, since even if you would add c2ffi-13.0.0.ebuild in future, it would be considered older than the first one.
I would recommend in this case something like c2ffi-13.0.0_pre20220626.ebuild.
Pull request CI reportReport generated at: 2022-07-18 18:36 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
No, in fact this is no pre-release. Unfortunately, this source project does not have any releases but a rather strange release protocol. Therefore in the past and after discussions with other gentoo reviewers, I have done it this way, and so far it has worked out. If there is a future version, I will name it c2ffi-13.0.0.somenewerdate.ebuild. |
|
Thank you for merging, and for the thorough review. |
Version bump to c2ffi-13.0.0.
Upstream bug: rpav/c2ffi#106
Gentoo bug: https://bugs.gentoo.org/840610