dev-libs/xapian-bindings: Fix the build with slibtool

[orbea]

Bug: https://bugs.gentoo.org/793428
Upstream-PR: xapian/xapian#322

I was unable to test the java support using the ebuild because of an unrelated issue, but I was able to test it manually using the release tarball including the tests.

[gentoo-bot]

Pull Request assignment

Submitter: @orbea
Areas affected: ebuilds
Packages affected: dev-libs/xapian-bindings

dev-libs/xapian-bindings: @blueness

Linked bugs

Bugs linked: 793428

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2022-07-22 02:09 UTC
Newest commit scanned: 9aadd1e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c1b60dd9ec/output.html

[vaukai]

Please also update virtual/{jre,jdk} according to https://wiki.gentoo.org/wiki/Java_Developer_Guide#JDK.2FJRE, needs rbump.

[orbea]

Thanks for pointing that out, now its obvious why the java build was failing. I force pushed with your suggestions. It works when bumping it to 1.7, but with many deprecated warnings so I used 1.8 instead.

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2022-07-22 06:24 UTC
Newest commit scanned: aa6b94a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f3a01a546f/output.html

[vaukai]

Thanks for pointing that out, now its obvious why the java build was failing. I force pushed with your suggestions. It works when bumping it to 1.7, but with many deprecated warnings so I used 1.8 instead.

»Never specify the JDK/JRE versions lower than the lowest available JDK/JRE in Gentoo.«
And the lowest we have in virtual/jdk and virtual/jre is actually 1.8.

Checking upstream what Java versions that package supports might be useful since java 17 does no longer support 1.6.
Or simply testing with openjdk-17 as system-vm.

[orbea]

Upstream has the following in their README and I tested with dev-java/openjdk-bin-17.0.3_p7:17::gentoo.

Java		Java bindings are generated with SWIG as of Xapian 1.3.0.
		The current API should be regarded as experimental - we plan
		to review it, possibly make some changes and then declare it
		stable early in the 1.4.x release series.  The minimum Java
		version we aim to support is JDK 1.6 (Java 6).  Recently tested
		with OpenJDK 1.8.0_77, 1.7.0_03, and 1.6.0_38.

https://github.com/xapian/xapian/blob/d25365df27300b191baa6217a8c9268a46d6cd6a/xapian-bindings/README#L26-L31

[vaukai]

Upstream has the following in their README and I tested with dev-java/openjdk-bin-17.0.3_p7:17::gentoo.

Thanks for checking and testing

[blueness]

Thanks. I've verified this works and pushed your patch. But! There are no stable versions of slibtool in the tree. So now a stabilization of xapian-bindins[java] will require sys-devel/slibtool to be stabilized first. Also you forgot to add the dep. I did that in a second commit.

[orbea]

@blueness GNU libtool is still default in gentoo and slibtool support is incomplete. Stabilizing slibtool will probably come later.

Please see this issue for details.

https://bugs.gentoo.org/765709

[blueness]

We can't have it both ways. If we want the slibtool fix, and we want a stable xapian-bindings[java], we need a stablie slibtool. What I can do is mask USE=java for 1.4.20-r1. Since it broken anyhow, no loss. If you want to find a fix with libtool, then that's the other option.

[orbea]

GNU libtool and slibtool do not conflict with each other and I am explicitly testing both when making PRs. The Gentoo wiki explains in more detail how to use it. As can be seen in the Gentoo bug tracker most of the issues have been fixed and what remains are mostly the more difficult cases where xapian-bindings was one.

https://wiki.gentoo.org/wiki/Slibtool#Usage