media-libs/assimp: fix version mismatch in pkg-config and cmake files

[waebbl]

Closes: https://bugs.gentoo.org/859862
Bug: assimp/assimp#4655
Signed-off-by: Bernd Waibel waebbl-gentoo@posteo.net

[gentoo-bot]

Pull Request assignment

Submitter: @waebbl
Areas affected: ebuilds
Packages affected: media-libs/assimp

media-libs/assimp: @waebbl, @gentoo/proxy-maint

Linked bugs

Bugs linked: 859862

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2022-07-24 14:59 UTC
Newest commit scanned: 8593c05
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/92848c347d/output.html

[waebbl]

I was thinking about doing a straight-to-stable push, due to the minor change involved. Feel free to ping me, if you think it's better to not drop to unstable keywords.

[waebbl]

Added missed fix in test file for version.

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2022-07-30 08:11 UTC
Newest commit scanned: e709adc
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/34cd70955e/output.html

[juippis]

I honestly do think you don't have to revbump for this fix. But I remember disagreeing with this before.

@thesamesam what's the right way?

[waebbl]

I was thinking, because it changes the installed files, it should be revbumped, so users / consumers are getting noticed, but I can change it to -r0 if desired.

[juippis]

Well I would weigh whether this revbump is fixing an issue, and in this case, it's an upstream issue, since it's only relevant for assimp's rdep developers. No one may actually "require" this, you're just closing a gentoo-related bug.

Just my thoughts.

[waebbl]

Fair enough. The only revdeps in tree, which have version requirements seem to be dev-qt/qt3d:5 (>=4.0.0) and sci-libs/dart (>=3.0.0), so they won't be affected by the change.

[thesamesam]

I honestly do think you don't have to revbump for this fix. But I remember disagreeing with this before.

@thesamesam what's the right way?

in general, yes, do, because of the consistency argument. In the event that something actually does want a proper fixed version, it's going to be very confusing if one system works and another doesn't.

[waebbl]

Thanks for merging!