Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-lang/icon/9.5.22e bump #26578

Closed
wants to merge 1 commit into from
Closed

Conversation

CheyenneWills
Copy link
Contributor

Signed-off-by: Cheyenne Wills cwills@witznd.net

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Jul 24, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-07-24 23:09 UTC
Newest commit scanned: d950f95
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1a013c6b6f/output.html

@CheyenneWills CheyenneWills changed the title dev-lang/icon/9.5.22e bump dev-lang/icon/9.5.22e bump [please reassign] Jul 31, 2022
@gentoo-bot gentoo-bot changed the title dev-lang/icon/9.5.22e bump [please reassign] dev-lang/icon/9.5.22e bump Jul 31, 2022
@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) labels Jul 31, 2022
Bug: https://bugs.gentoo.org/862552

Signed-off-by: Cheyenne Wills <cwills@witznd.net>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-07-31 15:21 UTC
Newest commit scanned: bff9b1d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c3eb4f9181/output.html

@CheyenneWills CheyenneWills changed the title dev-lang/icon/9.5.22e bump dev-lang/icon/9.5.22e bump [please reassign] Jul 31, 2022
@gentoo-bot gentoo-bot changed the title dev-lang/icon/9.5.22e bump [please reassign] dev-lang/icon/9.5.22e bump Jul 31, 2022
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @CheyenneWills
Areas affected: ebuilds
Packages affected: dev-lang/icon

dev-lang/icon: @CheyenneWills, @gentoo/proxy-maint

Linked bugs

Bugs linked: 862552


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jul 31, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-07-31 15:31 UTC
Newest commit scanned: e1823e3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ddda13e2a2/output.html

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a lot of cruft accumulated over the bumps,

 * SED: the following did not cause any changes
 *     sed -i -e 's/-o $LIBNAME $CFLAGS/& $LDFLAGS/g' ipl/cfuncs/mklib.sh || die;
 * no-op: -e s/-o $LIBNAME $CFLAGS/& $LDFLAGS/g
 * SED: the following did not cause any changes
 *     sed -i -e 's/$(CC) $(CFLAGS)/& $(LDFLAGS)/g' src/rtt/Makefile || die;
 * no-op: -e s/$(CC) $(CFLAGS)/& $(LDFLAGS)/g
 * SED: some expressions in the following did not cause any changes
 *     sed -i -e 's:-L/usr/X11R6/lib64::g' -e 's:-L/usr/X11R6/lib::g' -e 's:-I/usr/X11R6/include::g' -e 's:-I/usr/X11R6/include::g' -e '/^CFLAGS/d' Makedefs || die "sed of Makedefs failed";
 * no-op: -e s:-L/usr/X11R6/lib64::g
 * no-op: -e s:-L/usr/X11R6/lib::g
 * no-op: -e s:-I/usr/X11R6/include::g
 * no-op: -e s:-I/usr/X11R6/include::g

and while some may still be useful, a lot seems useless. These could be cleaned out perhaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants