Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-gfx/freecad: cleanup workbenches in 0.20 and live ebuild #26597

Closed
wants to merge 2 commits into from

Conversation

waebbl
Copy link
Contributor

@waebbl waebbl commented Jul 25, 2022

Upstream has dropped the ship and plot workbenches recently. The
patch reflects these changes and drops the USE flags for it.
Note, that the plot module is still available, only the workbench
for separate working with plots has been removed.

See also FreeCAD/FreeCAD#4971 and
FreeCAD/FreeCAD#4900

Bug: https://bugs.gentoo.org/858308#c2
Signed-off-by: Bernd Waibel waebbl-gentoo@posteo.net

Some additional typo fixes and minor code cleanup for live ebuild.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @waebbl
Areas affected: ebuilds
Packages affected: media-gfx/freecad

media-gfx/freecad: @waebbl, @gentoo/proxy-maint

Linked bugs

Bugs linked: 858308


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jul 25, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-07-25 23:04 UTC
Newest commit scanned: 2d9ebbd
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4856c7c34c/output.html

@waebbl waebbl force-pushed the freecad-cleanup-workbenches branch from 2d9ebbd to 33aaaeb Compare July 28, 2022 15:24
@waebbl
Copy link
Contributor Author

waebbl commented Jul 28, 2022

Remove two additional blocks in pkg_postinst, which I've missed.
Also removes the deletion of FindCoin3D.cmake from live ebuild, which has been dropped in FreeCAD/FreeCAD@7a198ca32e

Upstream has dropped the ship and plot workbenches recently. The
patch reflects these changes and drops the USE flags for it.
Note, that the plot module is still available, only the workbench
for separate working with plots has been removed.

See also FreeCAD/FreeCAD#4971 and
FreeCAD/FreeCAD#4900

Bug: https://bugs.gentoo.org/858308#c2
Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
Upstream has dropped the ship and plot workbenches recently. The
patch reflects these changes and drops the USE flags for it.
Note, that the plot module is still available, only the workbench
for separate working with plots has been removed.

See also FreeCAD/FreeCAD#4971 and
FreeCAD/FreeCAD#4900

Also fixes some typos in pkg_postinst and minor code cleanup.

Bug: https://bugs.gentoo.org/858308#c2
Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
@waebbl waebbl force-pushed the freecad-cleanup-workbenches branch from 33aaaeb to 987be1c Compare July 28, 2022 15:31
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-07-28 15:49 UTC
Newest commit scanned: 987be1c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2861f4daf4/output.html

@waebbl waebbl deleted the freecad-cleanup-workbenches branch July 29, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
3 participants