Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-shells/bash: Fix the builtin man pages #26669

Closed
wants to merge 1 commit into from
Closed

Conversation

orbea
Copy link
Contributor

@orbea orbea commented Jul 30, 2022

When using stricter man implementations such as app-text/mandoc the builtin man pages (i.e. man export) fail to display most of the manual unless the path for the bash.1 man page is correct.

I submitted this patch upstream in 2018 for Slackware who now carries this patch, but upstream wasn't very understanding suggesting distros should carry it themselves.

Upstream-PR: https://savannah.gnu.org/patch/?9592

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @orbea
Areas affected: ebuilds
Packages affected: app-shells/bash

app-shells/bash: @gentoo/base-system

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jul 30, 2022
@orbea orbea changed the title app-shells/bash: Fix the builtins man pages app-shells/bash: Fix the builtin man pages Jul 30, 2022
When using stricter man implementations such as app-text/mandoc the
builtin man pages (i.e. man export) fail to display most of the
manual unless the path for the bash.1 man page is correct.

Upstream-PR: https://savannah.gnu.org/patch/?9592
Signed-off-by: orbea <orbea@riseup.net>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-07-30 17:36 UTC
Newest commit scanned: 1bc4e13
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/be24f45880/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-07-30 17:46 UTC
Newest commit scanned: 65db26d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e9410b29ff/output.html

@floppym
Copy link
Contributor

floppym commented Jul 30, 2022

Chet mentions the install_builtins target... why don't we just call that instead?

floppym added a commit to floppym/gentoo that referenced this pull request Jul 30, 2022
This seems to be the intended name based on doc/Makefile.in.

This also fixes a rendering issue when the man pages are viewed with
mandoc.

Closes: gentoo#26669
Closes: gentoo#26673
Signed-off-by: Mike Gilbert <floppym@gentoo.org>
@orbea
Copy link
Contributor Author

orbea commented Jul 30, 2022

The install_builtins target only covers builtins.1 and not rbash.1. It also changes the file name from builtins.1 to bash_builtins.1, but that is probably an improvement.

--- /tmp/bash.orig      2022-07-30 15:27:29.073148134 -0700
+++ /tmp/bash.new       2022-07-30 15:32:14.296487070 -0700
@@ -33,6 +33,5 @@
 /usr/share/man
 /usr/share/man/man1
 /usr/share/man/man1/bash.1.gz
+/usr/share/man/man1/bash_builtins.1.gz
 /usr/share/man/man1/bashbug.1.gz
-/usr/share/man/man1/builtins.1.gz
-/usr/share/man/man1/rbash.1.gz

I could use install_builtins and slim down the patch to only rbash.1?

Edit: I see you already got there, thanks!

@orbea orbea deleted the bash branch July 31, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants