app-editors/vim, app-editors/vim-core: fix cros compile error during configure check for timer_create #26713
Conversation
Solution: Give a warning instead of an error. Signed-off-by: Varsha Teratipally <teratipally@google.com>
Pull Request assignmentSubmitter: @vteratipally app-editors/vim: @gentoo/vim Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2022-08-02 23:26 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
…ate) Problem: Configure check for timer_create may give wrong error. Solution: Give a warning instead of an error. Closes:#26713 Signed-off-by: Varsha Teratipally <teratipally@google.com> Signed-off-by: Sam James <sam@gentoo.org>
| @@ -79,6 +79,7 @@ src_prepare() { | |||
| if [[ ${PV} != 9999* ]] ; then | |||
| # Gentoo patches to fix runtime issues, cross-compile errors, etc | |||
| eapply "${WORKDIR}/vim-patches-vim-9.0.0049-patches" | |||
| eapply "{FILESDIR}/vim-9.0-fix-create-timer-for-cros-compiling.patch" | |||
There was a problem hiding this comment.
- Missing $
- This patch doesn't apply to 9.0.0049.
- No need for revbump if it's a build-time only issue like this (https://devmanual.gentoo.org/general-concepts/ebuild-revisions/index.html)
I've fixed that up. Thanks!
app-editors/vim, app-editors/vim-core: fix cros compile error during configure check for timer_create. So instead of reporting it as an error report it as the warning and ignore the check.
partial solution from vim/vim@5f6cae8
Signed-off-by: Varsha Teratipally teratipally@google.com