Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-sound/qtractor: enable VST2 support #26717

Closed
wants to merge 1 commit into from

Conversation

realnc
Copy link
Contributor

@realnc realnc commented Aug 3, 2022

A lot of MIDI instruments now come in the form of Linux VST plugins, so
not having VST support enabled seriously limits Qtractor's use cases
(since the primary use of Qtractor is as a MIDI sequencer) and forces
users to manually build from source.

VST2 support does not actually require any external deps. When the VST2
SDK is not found, it just uses the VST API declared in vestige.h which
comes with qtractor. So just unconditionally enable it, which is what
upstream does when cmake can't find the SDK.

VST3 support does require the VST3 SDK, which is not in portage, so keep
that disabled. Fortunately, VST3 is not that popular, at least for Linux
VST plugins.

Signed-off-by: Nikos Chantziaras realnc@gmail.com

A lot of MIDI instruments now come in the form of Linux VST plugins, so
not having VST support enabled seriously limits Qtractor's use cases
(since the primary use of Qtractor is as a MIDI sequencer) and forces
users to manually build from source.

VST2 support does not actually require any external deps. When the VST2
SDK is not found, it just uses the VST API declared in vestige.h which
comes with qtractor. So just unconditionally enable it, which is what
upstream does when cmake can't find the SDK.

VST3 support does require the VST3 SDK, which is not in portage, so keep
that disabled. Fortunately, VST3 is not that popular, at least for Linux
VST plugins.

Signed-off-by: Nikos Chantziaras <realnc@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @realnc
Areas affected: ebuilds
Packages affected: media-sound/qtractor

media-sound/qtractor: @gentoo/proaudio, simon.vanderveldt+gentoo[at]gmail.com, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Aug 3, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-08-03 07:11 UTC
Newest commit scanned: f916215
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4d415763e2/output.html

@realnc realnc deleted the qtractor-vst branch August 18, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants