Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sci-electronics/gtkwave: Bump to 3.3.111. Add gtk3 option. #26726

Closed
wants to merge 1 commit into from

Conversation

jvesely
Copy link
Contributor

@jvesely jvesely commented Aug 3, 2022

Use gtk3-fied source archive (gtkwave-gtk3).
Add gtk3 useflag to select between gtk2 and gtk3.
Drop no longer supported configure options (and fatlines useflag).

Closes: https://bugs.gentoo.org/856829
Bug: https://bugs.gentoo.org/856829
Signed-off-by: Jan Vesely jano.vesely@gmail.com

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @jvesely
Areas affected: ebuilds
Packages affected: sci-electronics/gtkwave

sci-electronics/gtkwave: @gentoo/sci-electronics

Linked bugs

Bugs linked: 856829


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Aug 3, 2022
@jvesely jvesely force-pushed the gtkwave branch 2 times, most recently from 0bb6064 to 4a994bd Compare August 3, 2022 17:07
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-08-03 17:21 UTC
Newest commit scanned: 4a994bd
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/72b83b1ae8/output.html

@jvesely
Copy link
Contributor Author

jvesely commented Aug 11, 2022

@SoapGentoo, you were the last to commit to sci-electronics/gtkwave. Any concerns about this PR? thank you.

@SoapGentoo
Copy link
Member

@jvesely in fact, why even keep the Gtk2 option?

@jvesely
Copy link
Contributor Author

jvesely commented Aug 11, 2022

@jvesely in fact, why even keep the Gtk2 option?

I can drop it, didn't really check how many gtk2 packages there are or whether ppl would prefer gtk2 over gtk3.

Use gtk3-fied source archive (gtkwave-gtk3).
Use gtk3 instead of gtk2 and switch the dependency.
Drop no longer supported configure options (and fatlines useflag).

Closes: https://bugs.gentoo.org/856829
Bug: https://bugs.gentoo.org/856829
Signed-off-by: Jan Vesely <jano.vesely@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-08-12 02:07 UTC
Newest commit scanned: 244aa3b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0482f3dfe1/output.html

@jvesely
Copy link
Contributor Author

jvesely commented Aug 18, 2022

@SoapGentoo, does the modified version look ok to you?

@jvesely
Copy link
Contributor Author

jvesely commented Aug 25, 2022

gentle ping

@AndrewAmmerlaan
Copy link
Member

Very nice, Thanks 👍

@jvesely jvesely deleted the gtkwave branch August 26, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
5 participants