New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sci-electronics/gtkwave: Bump to 3.3.111. Add gtk3 option. #26726
Conversation
Pull Request assignmentSubmitter: @jvesely sci-electronics/gtkwave: @gentoo/sci-electronics Linked bugsBugs linked: 856829 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
0bb6064
to
4a994bd
Compare
Pull request CI reportReport generated at: 2022-08-03 17:21 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
@SoapGentoo, you were the last to commit to sci-electronics/gtkwave. Any concerns about this PR? thank you. |
@jvesely in fact, why even keep the Gtk2 option? |
I can drop it, didn't really check how many gtk2 packages there are or whether ppl would prefer gtk2 over gtk3. |
Use gtk3-fied source archive (gtkwave-gtk3). Use gtk3 instead of gtk2 and switch the dependency. Drop no longer supported configure options (and fatlines useflag). Closes: https://bugs.gentoo.org/856829 Bug: https://bugs.gentoo.org/856829 Signed-off-by: Jan Vesely <jano.vesely@gmail.com>
Pull request CI reportReport generated at: 2022-08-12 02:07 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
@SoapGentoo, does the modified version look ok to you? |
gentle ping |
Very nice, Thanks 👍 |
Use gtk3-fied source archive (gtkwave-gtk3).
Add gtk3 useflag to select between gtk2 and gtk3.
Drop no longer supported configure options (and fatlines useflag).
Closes: https://bugs.gentoo.org/856829
Bug: https://bugs.gentoo.org/856829
Signed-off-by: Jan Vesely jano.vesely@gmail.com