Add support for Microsoft's d3d12 and dozen drivers #26746

FireBurn · 2022-08-05T12:57:44Z

These are usable under WSL, but can compile without WSL

The drivers require directx-headers to be built, I had issues building mesa with clang unless these were built with clang too

I'm not sure if video_cards_microsoft needs to be marked or not

gentoo-bot · 2022-08-05T13:02:15Z

Pull Request assignment

Submitter: @FireBurn
Areas affected: ebuilds
Packages affected: dev-util/directx-headers, media-libs/mesa

dev-util/directx-headers: @gentoo/proxy-maint (new package)
media-libs/mesa: @gentoo/x11

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

dev-util/directx-headers/directx-headers-1.606.3.ebuild

Arfrever · 2022-08-07T13:01:59Z

dev-util/directx-headers/directx-headers-1.606.3.ebuild

+	local emesonargs=()
+
+	emesonargs+=(
+		-Dbuild-test=false


emesonargs code is unnecessarily split. It can be:

local emesonargs=( -Dbuild-test=false )

dev-util/directx-headers/directx-headers-1.606.3.ebuild

Arfrever · 2022-08-07T13:07:56Z

dev-util/directx-headers/metadata.xml

+	</maintainer>
+	<maintainer type="person">
+		<email>sarnex@gentoo.org</email>
+		<name>Nick Sarnie</name>


@sarnex
See if you want to actually maintain it.

I'd happily put my own name down, but I think it has to be an official maintainer

I'm going to drop @sarnex as the maintainer since he hasn't expressed interest.

Thanks Matt, yeah no interest rn

Arfrever · 2022-08-07T13:23:09Z

Although opencl-headers, spirv-headers and vulkan-headers are currently in dev-util category, choice of this category seems questionable, since they are headers, not tools.
dev-libs or maybe gui-libs category seems better for headers packages. (E.g. part of dev-libs/boost is headers-only libraries.)
At least directx-headers and vulkan-headers seem to better fit gui-libs.
I am not sure how GUI-related are opencl-headers and spirv-headers.

FireBurn · 2022-08-07T13:36:28Z

When it's devices where in portage you want this, I'll make the necessary changes

Absolutely copyed from vulkan-headers, no point reinventing the wheel

FireBurn · 2022-08-09T17:34:11Z

@mattst88

mattst88 · 2022-08-09T18:02:23Z

unknown USE flag: 'video_cards_microsoft'

Need to add a description to profiles/desc/video_cards.desc and mask/unmask the flag in the arch profiles.

FireBurn · 2022-08-09T18:28:24Z

unknown USE flag: 'video_cards_microsoft'

Need to add a description to profiles/desc/video_cards.desc and mask/unmask the flag in the arch profiles.

Ah thanks, I couldn't figure out where that was needing to go

FireBurn · 2022-08-09T18:36:28Z

@mattst88 how would you feel about me putting you down as the maintainer of the new ebuild, or can I put myself down as a proxy-maintainer?

gentoo-repo-qa-bot · 2022-08-09T18:46:59Z

Pull request CI report

Report generated at: 2022-08-09 18:46 UTC
Newest commit scanned: e674339
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/2b883a2baa/output.html

BratishkaErik · 2022-08-24T12:06:15Z

I hope you'll will find it useful microsoft/DirectXShaderCompiler#4178

FireBurn · 2022-08-24T22:52:04Z

@mattst88 Ping

This is required to enable the d3d12 and dozen drivers in mesa This enables OpenGL and Vulkan support within WSL Signed-off-by: Mike Lothian <mike@fireburn.co.uk>

gentoo-repo-qa-bot · 2022-09-04T09:42:40Z

Pull request CI report

Report generated at: 2022-09-04 09:42 UTC
Newest commit scanned: e1e448e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f58e6de65f/output.html

This adds supoprt for the d3d12 gallium driver and the dozen vulkan driver. It uses the video_cards_microsoft flag It optionally adds in video acceleration if vaapi or vdpau is enabled It's been compiled tested with GCC 12.1 & Clang 14 If building mesa with Clang, directx-headers must be build with clang too, otherwise you'll experience linking errors Signed-off-by: Mike Lothain <mike@fireburn.co.uk>

gentoo-repo-qa-bot · 2022-09-04T10:12:50Z

Pull request CI report

Report generated at: 2022-09-04 10:12 UTC
Newest commit scanned: bac7158
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/973f930a51/output.html

mattst88

I'll make the changes locally I noted. Thanks for your contribution (and your patience!)

mattst88 · 2022-09-06T15:16:25Z

dev-util/directx-headers/directx-headers-1.606.4.ebuild

@@ -0,0 +1,30 @@
+# Copyright 1999-2023 Gentoo Authors


Not yet 2023.

mattst88 · 2022-09-06T15:16:33Z

dev-util/directx-headers/directx-headers-9999.ebuild

@@ -0,0 +1,30 @@
+# Copyright 1999-2023 Gentoo Authors


Not yet 2023.

mattst88 · 2022-09-06T15:16:50Z

dev-util/directx-headers/directx-headers-9999.ebuild

+
+multilib_src_configure() {
+	local emesonargs=(
+		-Dbuild-test=false


Why do we disable the tests?

mattst88 · 2022-09-06T15:17:10Z

dev-util/directx-headers/metadata.xml

+	</maintainer>
+	<maintainer type="person">
+		<email>sarnex@gentoo.org</email>
+		<name>Nick Sarnie</name>


I'm going to drop @sarnex as the maintainer since he hasn't expressed interest.

mattst88 · 2022-09-06T15:18:01Z

media-libs/mesa/mesa-9999.ebuild

@@ -25,7 +25,7 @@ SLOT="0"
 RESTRICT="!test? ( test )"

 RADEON_CARDS="r300 r600 radeon radeonsi"
-VIDEO_CARDS="${RADEON_CARDS} freedreno intel lima nouveau panfrost v3d vc4 virgl vivante vmware"
+VIDEO_CARDS="${RADEON_CARDS} freedreno intel lima microsoft nouveau panfrost v3d vc4 virgl vivante vmware"


I'm going to rename VIDEO_CARDS="microsoft" to VIDEO_CARDS="d3d12". I think that's a little clearer.

mattst88 · 2022-09-06T15:18:16Z

media-libs/mesa/mesa-9999.ebuild

@@ -225,6 +226,7 @@ pkg_pretend() {
 	if use vulkan; then
 		if ! use video_cards_freedreno &&
 		   ! use video_cards_intel &&
+		   ! use video_cards_microsoft &&
 		   ! use video_cards_radeonsi &&
 		   ! use video_cards_v3d; then
 			ewarn "Ignoring USE=vulkan     since VIDEO_CARDS does not contain freedreno, intel, radeonsi, or v3d"


Forgot to list microsoft here.

mattst88 · 2022-09-06T15:18:41Z

profiles/arch/x86/use.mask

@@ -129,6 +129,7 @@
 -video_cards_i965
 -video_cards_intel
 -video_cards_iris
+-video_cards_microsoft


Do we really want to allow this on x86? (I have no idea)

mattst88 · 2022-09-06T15:20:35Z

One commit has

Signed-off-by: Mike Lothian <mike@fireburn.co.uk>

while the other has

Signed-off-by: Mike Lothain <mike@fireburn.co.uk>

Definitely run pkgcheck scan --commits. Super useful for catching all kinds of small mistakes like this.

This adds support for the d3d12 gallium driver and the dozen vulkan driver. It uses the video_cards_microsoft flag It optionally adds in video acceleration if vaapi or vdpau is enabled It's been compiled tested with GCC 12.1 & Clang 14 If building mesa with Clang, directx-headers must be build with clang too, otherwise you'll experience linking errors Closes: gentoo#26746 Signed-off-by: Mike Lothain <mike@fireburn.co.uk> Signed-off-by: Matt Turner <mattst88@gentoo.org>

gentoo-bot added new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Aug 5, 2022

FireBurn force-pushed the mesa-microsoft branch from 1cf09a2 to 8491d92 Compare August 6, 2022 16:54

ConiKost reviewed Aug 6, 2022

View reviewed changes

dev-util/directx-headers/directx-headers-1.606.3.ebuild Outdated Show resolved Hide resolved

Arfrever reviewed Aug 7, 2022

View reviewed changes

FireBurn force-pushed the mesa-microsoft branch 2 times, most recently from 049ba38 to 92d8cbb Compare August 9, 2022 17:33

FireBurn force-pushed the mesa-microsoft branch from 92d8cbb to 873bdf8 Compare August 9, 2022 17:35

FireBurn force-pushed the mesa-microsoft branch from 873bdf8 to e674339 Compare August 9, 2022 18:35

dev-util/directx-headers: Add new ebuild

a8f0904

This is required to enable the d3d12 and dozen drivers in mesa This enables OpenGL and Vulkan support within WSL Signed-off-by: Mike Lothian <mike@fireburn.co.uk>

FireBurn force-pushed the mesa-microsoft branch from e674339 to e1e448e Compare September 4, 2022 09:28

FireBurn force-pushed the mesa-microsoft branch from e1e448e to bac7158 Compare September 4, 2022 10:03

mattst88 approved these changes Sep 6, 2022

View reviewed changes

gentoo-bot closed this in a4ca7cc Sep 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Microsoft's d3d12 and dozen drivers #26746

Add support for Microsoft's d3d12 and dozen drivers #26746

FireBurn commented Aug 5, 2022

gentoo-bot commented Aug 5, 2022

Arfrever Aug 7, 2022

Arfrever Aug 7, 2022

FireBurn Aug 7, 2022

mattst88 Sep 6, 2022

sarnex Sep 6, 2022 •

edited

Arfrever commented Aug 7, 2022

FireBurn commented Aug 7, 2022

FireBurn commented Aug 9, 2022

mattst88 commented Aug 9, 2022

FireBurn commented Aug 9, 2022

FireBurn commented Aug 9, 2022

gentoo-repo-qa-bot commented Aug 9, 2022

BratishkaErik commented Aug 24, 2022

FireBurn commented Aug 24, 2022

gentoo-repo-qa-bot commented Sep 4, 2022

gentoo-repo-qa-bot commented Sep 4, 2022

mattst88 left a comment

mattst88 Sep 6, 2022

mattst88 Sep 6, 2022

mattst88 Sep 6, 2022

mattst88 Sep 6, 2022

mattst88 Sep 6, 2022

mattst88 Sep 6, 2022

mattst88 Sep 6, 2022

mattst88 commented Sep 6, 2022

Add support for Microsoft's d3d12 and dozen drivers #26746

Add support for Microsoft's d3d12 and dozen drivers #26746

Conversation

FireBurn commented Aug 5, 2022

gentoo-bot commented Aug 5, 2022

Pull Request assignment

Linked bugs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sarnex Sep 6, 2022 • edited

Choose a reason for hiding this comment

Arfrever commented Aug 7, 2022

FireBurn commented Aug 7, 2022

FireBurn commented Aug 9, 2022

mattst88 commented Aug 9, 2022

FireBurn commented Aug 9, 2022

FireBurn commented Aug 9, 2022

gentoo-repo-qa-bot commented Aug 9, 2022

Pull request CI report

BratishkaErik commented Aug 24, 2022

FireBurn commented Aug 24, 2022

gentoo-repo-qa-bot commented Sep 4, 2022

Pull request CI report

gentoo-repo-qa-bot commented Sep 4, 2022

Pull request CI report

mattst88 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mattst88 commented Sep 6, 2022

sarnex Sep 6, 2022 •

edited