Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gui-apps/tuigreet: version bump and add myself as maintainer #26797

Closed
wants to merge 4 commits into from
Closed

gui-apps/tuigreet: version bump and add myself as maintainer #26797

wants to merge 4 commits into from

Conversation

mm1ke
Copy link
Contributor

@mm1ke mm1ke commented Aug 9, 2022

Hi,

This is a simple version bump for tuigreet. Since it's maintainer-needed i'll also decided to take over it.

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Aug 9, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-08-09 17:01 UTC
Newest commit scanned: dcfdf4e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/fa09afa759/output.html

@DarkDefender
Copy link
Contributor

Awesome!
Could you add this fix to the live and 0.8.0 ebuild?
https://bugs.gentoo.org/832445

@mm1ke
Copy link
Contributor Author

mm1ke commented Aug 18, 2022

Awesome! Could you add this fix to the live and 0.8.0 ebuild? https://bugs.gentoo.org/832445

Hi, thanks for the hint.
I've included your changes from the bug report. Should be fixed with 0.8.0 and 9999 then.

@mm1ke mm1ke changed the title gui-apps/tuigreet: version bump and add myself as maintainer [please reassign] gui-apps/tuigreet: version bump and add myself as maintainer Aug 18, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-08-18 17:31 UTC
Newest commit scanned: 7449acc
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/7bbd2bc882/output.html

@gentoo-bot gentoo-bot changed the title [please reassign] gui-apps/tuigreet: version bump and add myself as maintainer gui-apps/tuigreet: version bump and add myself as maintainer Aug 18, 2022
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @mm1ke
Areas affected: ebuilds
Packages affected: gui-apps/tuigreet

gui-apps/tuigreet: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 832445

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits. labels Aug 18, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-08-18 17:41 UTC
Newest commit scanned: 7449acc
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ec9d9aeb9c/output.html

@DarkDefender
Copy link
Contributor

I would do the version bump and then do a separate commit that integrates the patch.
This way you can have a Closes: https://bugs.gentoo.org/832445 in the commit message to automatically close the bug report when the commit is merged.

Now it seems a bit weird that the addition is split into the bump commit and the EAPI commit.

@mm1ke
gui-apps/tuigreet: version bump (0.8.0)
f5c0ef6 
Signed-off-by: Michael Mair-Keimberger <mmk@levelnine.at>
Portage 3.0.34 / pkgdev 0.2.1 / pkgcheck 0.10.12
@mm1ke
gui-apps/tuigreet: EAPI8 bump
88496fe 
Signed-off-by: Michael Mair-Keimberger <mmk@levelnine.at>
Portage 3.0.34 / pkgdev 0.2.1 / pkgcheck 0.10.12
@mm1ke
gui-apps/tuigreet: fix remember username or session, bug 832445
49ec793 
Closes: https://bugs.gentoo.org/832445
Signed-off-by: Michael Mair-Keimberger <mmk@levelnine.at>
Portage 3.0.34 / pkgdev 0.2.1 / pkgcheck 0.10.12
@mm1ke
gui-apps/tuigreet: add myself as maintainer
7493c33 
Signed-off-by: Michael Mair-Keimberger <mmk@levelnine.at>
Portage 3.0.34 / pkgdev 0.2.1 / pkgcheck 0.10.12
@mm1ke
Copy link
Contributor Author

mm1ke commented Aug 19, 2022

@DarkDefender good point, i've updated the PR and made a separate commit for the fix.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-08-19 18:47 UTC
Newest commit scanned: 7493c33
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c434dc3095/output.html

@DarkDefender
Copy link
Contributor

@mm1ke Thanks! Looks good to me now!

@thesamesam I guess it is ok to poke you about getting this merged?

@gentoo-bot gentoo-bot closed this in 1cee0cc Sep 5, 2022
@DarkDefender DarkDefender mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
5 participants
@mm1ke @gentoo-repo-qa-bot @DarkDefender @gentoo-bot @juippis