www-apps/webdavcgi: Version bump to 1.1.1 #2683
Conversation
|
@gentoo/proxy-maint |
gktrk
added
bugfix
assigned
| <maintainer type="person"> | ||
| <email>c.affolter@stepping-stone.ch</email> | ||
| <name>Christian Affolter</name> | ||
| <description>Maintainer</description> |
There was a problem hiding this comment.
The <description /> tag is in the metadata.xml of the old webdavcgi ebuild, that's why I added it here as well. Do you want me to remove it?
| </maintainer> | ||
| <maintainer type="person"> | ||
| <email>dev-zero@gentoo.org</email> | ||
| <description>Proxy maintainer</description> |
There was a problem hiding this comment.
Again, <description> isn't needed. Also, I can't commit this without dev-zero's approval if he is to be in the metadata. If you want to maintain this through the proxy-maintainers projects (like www-apps/webdavcgi), we need the following in the metadata as well:
<maintainer type="project">
<email>proxy-maint@gentoo.org</email>
<name>Proxy Maintainers</name>
</maintainer>
There was a problem hiding this comment.
Sure, will add the proxy-maint block as well.
There was a problem hiding this comment.
If we add the proxy-maint block with dev-zero's permission, you don't need the description tags on yourself and him.
| HOMEPAGE="http://webdavcgi.sourceforge.net/" | ||
| SRC_URI="mirror://sourceforge/${PN}/${P}.tar.bz2" | ||
|
|
||
| LICENSE="GPL-3" |
There was a problem hiding this comment.
The license is very likely GPL-3+. See: https://github.com/clueware/webdavcgi/blob/master/lib/perl/WebInterface.pm#L9
There was a problem hiding this comment.
You're right, I will adapt that accordingly.
| dev-perl/URI | ||
| dev-perl/UUID-Tiny | ||
| dev-perl/XML-Simple | ||
| git? ( dev-vcs/git ) |
There was a problem hiding this comment.
Can we double check that this isn't dev-vcs/git[perl] ?
There was a problem hiding this comment.
Should be correct, according to the GIT backend documentation, one has to install the git binary.
|
|
||
| export WEBDAVWRAPPERS | ||
|
|
||
| local wrapper |
There was a problem hiding this comment.
Is this indentation a stylistic choice? If not, let's align it with the rest of the code block.
There was a problem hiding this comment.
No, it's simply a broken indentation, thanks for spotting it.
| elog "The WebDAV CGI config is located at ${WEBDAVCONFIG}." | ||
| elog | ||
| elog "An example Apache HTTP server configuration snippet is available in" | ||
| elog "/usr/share/doc/${PF} in the file ${APACHEEXAMPLECONFIG}" |
There was a problem hiding this comment.
Better to use ${ROOT%/}/usr/share/doc/${PF} here
There was a problem hiding this comment.
OK, will change that as well.
|
Are there any security implications to the mode 1777 ? |
There might be security implications if one runs other services on the same system or has system users which have direct access to the file system. They might be able to access temporary or deleted files (in case the thrash feature has been enabled), similar to files within |
|
@gktrk Thanks a lot for taking the time to review this PR. Do you prefer new separate commits for addressing the above issues, or shall I squash/rebase the changes with the original commits? |
|
I pinged dev-zero for his approval on IRC. We prefer squashing them. |
Required dependency for >=www-apps/webdavcgi-0.8.5
Added new upstream 1.1.1 WebDAV CGI release with the following changes: * Switched to EAPI 6 * Updated dependencies * Moved temporary directories from /var/cache to /var/tmp (to make QA happy) * Pre-create trash and optimizer directory * Added updated Apache HTTP configuration snipped for version 2.4 * Added updated wedav 1.1 configuration * Added note for systemd users Gentoo-Bug: 595060
paraenggu
force-pushed
the
webdavcgi-1.1.1
branch
from
8ba2359
to
d63c0df
Compare
|
@gktrk I've addressed all your comments and rebased/squashed the changes with the original commits. |
|
Merged in e506143...4c4dd65. Thanks! |
Needed to keep ::gentoo masks from affecting ::haskell packages ::gentoo PR: gentoo/gentoo#2683 Signed-off-by: hololeap <hololeap@users.noreply.github.com>
Needed to keep ::gentoo masks from affecting ::haskell packages ::gentoo PR: gentoo/gentoo#2683 Signed-off-by: hololeap <hololeap@users.noreply.github.com>
New version of www-apps/webdavcgi ebuild including the required dev-perl/DateTime-Format-Human-Duration dependency.
Gentoo-Bug: https://bugs.gentoo.org/595060
@dev-zero could you please review and merge? Thanks.