-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-editor/{vscodium|vscode}: disable update server on install #26897
Conversation
This is also applicable to vscode. As portage manages the updates for these packages it is undesirable to receive notifications about updates that may not apply. This removes the reference to the update server. Signed-off-by: Joe Kappus <joe@wt.gd>
Pull Request assignmentSubmitter: @joecool1029 app-editors/vscodium: @AdelKS, @arthurzam, @gentoo/proxy-maint Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also do the same to vscode
in same PR?
Also, this needs a revision bump, as it affects installed files.
Pull request CI reportReport generated at: 2022-08-17 10:52 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Is it ok to remove the old revisions? Or do I leave those in? |
Also fixed indent, thanks arthurzam! Signed-off-by: Joe Kappus <joe@wt.gd>
Remove the reference to update server which will disable automatic update check/notification. Signed-off-by: Joe Kappus <joe@wt.gd>
Pull request CI reportReport generated at: 2022-08-17 11:21 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix indentation of you changes!
It should be a single TAB in all of them 😃
I really need to fix my editor. Signed-off-by: Joe Kappus <joe@wt.gd>
Pull request CI reportReport generated at: 2022-08-17 23:06 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Sorry about that, I will fix the editor situation and try to get more sleep! |
VSCodium/vscodium#1189 Some discussion with upstream on the update check situation. |
This is also applicable to vscode. As portage manages
the updates for these packages it is undesirable to receive
notifications about updates that may not apply.
This removes the reference to the update server.
Signed-off-by: Joe Kappus joe@wt.gd