Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-editor/{vscodium|vscode}: disable update server on install #26897

Closed

Conversation

joecool1029
Copy link
Contributor

This is also applicable to vscode. As portage manages
the updates for these packages it is undesirable to receive
notifications about updates that may not apply.

This removes the reference to the update server.

Signed-off-by: Joe Kappus joe@wt.gd

This is also applicable to vscode. As portage manages
the updates for these packages it is undesirable to receive
notifications about updates that may not apply.

This removes the reference to the update server.

Signed-off-by: Joe Kappus <joe@wt.gd>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @joecool1029
Areas affected: ebuilds
Packages affected: app-editors/vscodium

app-editors/vscodium: @AdelKS, @arthurzam, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Aug 17, 2022
Copy link
Member

@arthurzam arthurzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also do the same to vscode in same PR?
Also, this needs a revision bump, as it affects installed files.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-08-17 10:52 UTC
Newest commit scanned: 3c0797e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/882c2c305b/output.html

@joecool1029
Copy link
Contributor Author

Can you also do the same to vscode in same PR? Also, this needs a revision bump, as it affects installed files.

Is it ok to remove the old revisions? Or do I leave those in?

Also fixed indent, thanks arthurzam!

Signed-off-by: Joe Kappus <joe@wt.gd>
Remove the reference to update server which
will disable automatic update check/notification.

Signed-off-by: Joe Kappus <joe@wt.gd>
@joecool1029 joecool1029 changed the title app-editor/vscodium: disable update server on install app-editor/{vscodium|vscode}: disable update server on install Aug 17, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-08-17 11:21 UTC
Newest commit scanned: f794aa8
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8799905547/output.html

@arthurzam arthurzam self-assigned this Aug 17, 2022
Copy link
Member

@arthurzam arthurzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix indentation of you changes!
It should be a single TAB in all of them 😃

I really need to fix my editor.

Signed-off-by: Joe Kappus <joe@wt.gd>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-08-17 23:06 UTC
Newest commit scanned: 5a0a07e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/47a0fc25d5/output.html

@joecool1029
Copy link
Contributor Author

Please fix indentation of you changes!
It should be a single TAB in all of them 😃

Sorry about that, I will fix the editor situation and try to get more sleep!

@joecool1029
Copy link
Contributor Author

VSCodium/vscodium#1189 Some discussion with upstream on the update check situation.

@joecool1029 joecool1029 deleted the vscodium_disable_updater branch August 22, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants