Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-im/telegram-desktop: Hotfix for proper Qt selection #26980

Closed
wants to merge 1 commit into from
Closed

net-im/telegram-desktop: Hotfix for proper Qt selection #26980

wants to merge 1 commit into from

Conversation

mid-kid
Copy link
Contributor

@mid-kid mid-kid commented Aug 23, 2022

@gyakovlev

Tinderbox is a lifesaver...

@mid-kid
net-im/telegram-desktop: Hotfix for proper Qt selection
6b8c6c3 
They changed the variable for this, causing the build to prefer qt6 when
it's available.

Closes: https://bugs.gentoo.org/866157
Thanks-to: Agostino Sarubbo <ago@gentoo.org>
Signed-off-by: Esteve Varela Colominas <esteve.varela@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @mid-kid
Areas affected: ebuilds
Packages affected: net-im/telegram-desktop

net-im/telegram-desktop: @mid-kid, @gentoo/proxy-maint

Linked bugs

Bugs linked: 866157

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Aug 23, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-08-23 16:07 UTC
Newest commit scanned: 6b8c6c3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/24318f713e/output.html

@mid-kid
Copy link
Contributor Author

mid-kid commented Aug 31, 2022

@juippis this is a bit of a pressing hotfix unfortunately...

@a17r
Copy link
Member

a17r commented Aug 31, 2022

Qt6 is still masked...

juippis
juippis approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think we don't have to revbump for this. Currently testing so I have no idea whether building telegram-desktop takes long or not, but my initial thoughts about the subject.

@mid-kid
Copy link
Contributor Author

mid-kid commented Aug 31, 2022 •
edited
Loading

I will definitely revbump this because some people who don't have the qt6 flag enabled might've gotten the qt6 version instead of the qt5 version installed if they happened to have qt6 installed in the system. It's probably a very small percentage but still, this is the sort of thing you need revbumps for...

@thesamesam
Copy link
Member

yes, fixing automagic deps requires it

@juippis
Copy link
Member

juippis commented Aug 31, 2022

I would say since it's masked and all, having qt6 installed you know to expect trouble. And it should be for power users only.

Anyway I can't even test this due to bug 832963

juippis
juippis approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not the smallest of packages to recompile... but not getting any weird QA notice now. I got:

 * VDB: detected possibly incorrect RDEPEND (net-im/telegram-desktop-4.1.1-r1)
 * dev-libs/jemalloc:=     < 
 *                         > dev-libs/glib:2
 *                         > dev-libs/libsigc++:2
 * dev-libs/xxhash         < 
 * media-libs/fontconfig:= < 
 *                         > media-libs/libjpeg-turbo:=
 * media-libs/opus:=       < 
 * media-libs/tg_owt       | media-libs/tg_owt:=
 *                         > x11-libs/xcb-util-keysyms

so might as well add those missing deps and subslot binders while revbumping.

@mid-kid
Copy link
Contributor Author

mid-kid commented Aug 31, 2022 •
edited
Loading

What generates that message? I've never seen anything like it.
That said, some of these dependencies were left out as for example jpeg-turbo is used through Qt and glib through glibmm. I'm not sure tdesktop uses them directly.

@thesamesam
Copy link
Member

thesamesam commented Aug 31, 2022 •
edited
Loading

What generates that message? I've never seen anything like it.
That said, some of these dependencies were left out as for example jpeg-turbo is used through Qt and glib through glibmm. I'm not sure tdesktop uses them directly.

iwdevtools

also, the output is saying you're linked directly against them (although glib can be an interesting one sometimes)

@gentoo-bot gentoo-bot closed this in ff21849 Sep 1, 2022
@mid-kid mid-kid deleted the telegram branch October 1, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
6 participants
@mid-kid @gentoo-bot @gentoo-repo-qa-bot @a17r @thesamesam @juippis