Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mail-client/alpine: enable threads by default #27138

Closed
wants to merge 1 commit into from
Closed

mail-client/alpine: enable threads by default #27138

wants to merge 1 commit into from

Conversation

hhoffstaette
Copy link
Contributor

Closes: https://bugs.gentoo.org/868396
Signed-off-by: Holger Hoffstätte holger@applied-asynchrony.com

@hhoffstaette
Copy link
Contributor Author

We just let autoconf detect it, and since all relevant Linux arches have pthreads support this will do The Right Thing.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @hhoffstaette
Areas affected: ebuilds
Packages affected: mail-client/alpine

mail-client/alpine: @robert7k, @gentoo/proxy-maint

Linked bugs

Bugs linked: 868396

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Sep 4, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-09-04 13:37 UTC
Newest commit scanned: 3a99a94
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/adf7b4ad60/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-09-05 14:37 UTC
Newest commit scanned: 237d974
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/376d0b7880/output.html

robert7k
robert7k approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@robert7k robert7k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that autoconf enables pthreads by default.

@hhoffstaette
mail-client/alpine: enable threads by default
b5611cb 
Upstream enables pthreads by default, so enable it unconditionally.

Closes: https://bugs.gentoo.org/868396
Signed-off-by: Holger Hoffstätte holger@applied-asynchrony.com
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-09-06 06:32 UTC
Newest commit scanned: b5611cb
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/520a69b8e1/output.html

@thesamesam
Copy link
Member

Thanks, I've git mv'd for this.

@hhoffstaette hhoffstaette deleted the alpine-threading branch September 10, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesamesam thesamesam thesamesam left review comments

@juippis juippis juippis left review comments

@robert7k robert7k robert7k approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
6 participants
@hhoffstaette @gentoo-bot @gentoo-repo-qa-bot @thesamesam @robert7k @juippis