games-action/polymc: add patch for explicitly include QDebug in PollServer.cpp #27201
Conversation
Pull Request assignmentSubmitter: @flowln games-action/polymc: @flowln, Linked bugsBugs linked: 869395 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
self-maintained
Pull request CI reportReport generated at: 2022-09-10 21:37 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| From c2b3567cb18e81a5f82c95c2c323b19488d62ed8 Mon Sep 17 00:00:00 2001 | ||
| From: Thiago Donato Ferreira <flowlnlnln@gmail.com> | ||
| Date: Sat, 10 Sep 2022 17:59:27 -0300 | ||
| Subject: [PATCH] fix: add explicit QDebug include in PollServer | ||
|
|
||
| Signed-off-by: Thiago Donato Ferreira <flowlnlnln@gmail.com> | ||
| --- | ||
| libraries/katabasis/src/PollServer.cpp | 2 ++ | ||
| 1 file changed, 2 insertions(+) | ||
|
|
There was a problem hiding this comment.
We usually strip most of the patch's header to save space since most of the information in there is not relevant for us.
There was a problem hiding this comment.
Oh sorry, the quazip patches have it all so I just did the same :c
| @@ -85,6 +85,10 @@ RDEPEND=" | |||
| virtual/opengl | |||
| " | |||
|
|
|||
| PATCHES=( | |||
| "${FILESDIR}"/${PN}-explicit_include_in_PollServer.patch | |||
There was a problem hiding this comment.
The name of the patch should include the version number it was first introduced in, i.e. PN --> P
| @@ -85,6 +85,10 @@ RDEPEND=" | |||
| virtual/opengl | |||
| " | |||
|
|
|||
| PATCHES=( | |||
| "${FILESDIR}"/${PN}-explicit_include_in_PollServer.patch | |||
There was a problem hiding this comment.
And here that would be PN --> PN-1.4.1
This seems to be a problem with early 5.12 Qt versions, since newer versions don't have this problem. Somewhere along the way, QDebug was probably added as a implicit include to this file. Closes: https://bugs.gentoo.org/869395 Signed-off-by: Thiago Donato Ferreira <flowlnlnln@gmail.com>
flowln
force-pushed
the
polymc-missing-include
branch
from
0e1450e
to
3ee7094
Compare
Pull request CI reportReport generated at: 2022-09-11 12:37 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Thanks 👍 |
I hope I changed the ebuild names correctly 😬
Bug: https://bugs.gentoo.org/869395