x11-wm/mutter & gnome-base/gnome-shell: Version bump to 43.0, dev-libs/gjs: bump to 1.74.0 #27315
Conversation
Pull Request assignmentSubmitter: @Schievel1 x11-wm/mutter: @gentoo/gnome Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. Missing GCO sign-offPlease read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Schievel1
force-pushed
the
mutter-bump
branch
2 times, most recently
from
6785f18
to
452b221
Compare
Pull request CI reportReport generated at: 2022-09-18 07:27 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| src_test() { | ||
| gnome2_environment_reset # Avoid dconf that looks at XDG_DATA_DIRS, which can sandbox fail if flatpak is installed | ||
| glib-compile-schemas "${BUILD_DIR}"/data | ||
| GSETTINGS_SCHEMA_DIR="${BUILD_DIR}"/data meson_src_test --setup=CI |
There was a problem hiding this comment.
Do the tests work for you? They timeout and fail for me:
1/195 mutter:cogl+cogl/conform / cogl-test-atlas-migration-gl TIMEOUT 300.00s (exit status 133 or signal 5 SIGTRAP)
>>> MUTTER_DEBUG_DUMMY_MODE_SPECS=800x600@10.0 G_TEST_SRCDIR=/var/tmp/portage/x11-wm/mutter-43.0/work/mutter-43.0/src/tests/cogl/conform G_TEST_BUILDDIR=/var/tmp/portage/x11-wm/mutter-43.0/work/mutter-43.0-build/src/tests/cogl/conform MALLOC_PERTURB_=189 COGL_DRIVER=gl MUTTER_TEST_PLUGIN_PATH=/var/tmp/portage/x11-wm/mutter-43.0/work/mutter-43.0-build/src/compositor/plugins/libdefault.so G_ENABLE_DIAGNOSTIC=0 /var/tmp/portage/x11-wm/mutter-43.0/work/mutter-43.0/src/tests/meta-dbus-runner.py -- /usr/bin/xvfb-run -a -s '+iglx -noreset' /var/tmp/portage/x11-wm/mutter-43.0/work/mutter-43.0-build/src/tests/cogl/conform/cogl-test-atlas-migration
✀
stdout:
# random seed: R02S7f496815ebc0e91b12aad76b9ff45808
# libmutter-MESSAGE: Running Mutter Test (using mutter 43.0) as a Wayland display server
# GLib-GIO-DEBUG: _g_io_module_get_default: Found default implementation memory (GMemorySettingsBackend) for ‘gsettings-backend’
# GLib-GIO-DEBUG: Using cross-namespace EXTERNAL authentication (this will deadlock if server is GDBus < 2.73.3)
# libmutter-MESSAGE: Created surfaceless renderer without GPU
# GVFS-DEBUG: org.gtk.vfs.MountTracker.listMountableInfo call failed: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.gtk.vfs.Daemon was not provided by any .service files (g-dbus-error-quark, 2)
#
# GLib-GIO-DEBUG: _g_io_module_get_default: Found default implementation local (GLocalVfs) for ‘gio-vfs’
# libmutter-MESSAGE: Disabling DMA buffer screen sharing (not hardware accelerated)
# libmutter-MESSAGE: Disabling DMA buffer screen sharing (implicit modifiers not supported)
# libmutter-MESSAGE: Using Wayland display name 'mutter-test-display'
1..1
ok 1 /atlas-migration
Bail out! GLib-GObject-FATAL-CRITICAL: g_object_unref: assertion 'G_IS_OBJECT (object)' failed
stderr:
Starting D-Bus daemons (session & system)...
Starting mocked services...
Running test case...
libmutter-Message: 22:28:15.056: Running Mutter Test (using mutter 43.0) as a Wayland display server
libEGL warning: failed to open /dev/dri/renderD128: Permission denied
libEGL warning: failed to open /dev/dri/card0: Permission denied
libmutter-Message: 22:28:15.088: Created surfaceless renderer without GPU
libmutter-Message: 22:28:15.103: Disabling DMA buffer screen sharing (not hardware accelerated)
libmutter-Message: 22:28:15.103: Disabling DMA buffer screen sharing (implicit modifiers not supported)
libmutter-Message: 22:28:15.103: Using Wayland display name 'mutter-test-display'
Window manager warning: Failed to set environment variable WAYLAND_DISPLAY for gnome-session: GDBus.Error:org.freedesktop.DBus.Error.NameHasNoOwner: Name "org.gnome.SessionManager" does not exist
There was a problem hiding this comment.
yes I asked in the irc channel about this, too. Is this because gnome-shell-43.0 is missing?
This is also the reason I kept this PR draft
There was a problem hiding this comment.
Nope, have gnome-shell-43.0 installed, still can not get the tests to pass
There was a problem hiding this comment.
I also tried to run it yesterday, once I got gnome-shell-43.0 installed, and it crashes right from the start, when gdm is started
There was a problem hiding this comment.
Here is the syslog when I try to start gdm. https://pastebin.com/bWNcPvkM
There was a problem hiding this comment.
I've bisected two things causing the tests to fail:
- Tests fail with
-Dsound_player=false: https://gitlab.gnome.org/GNOME/mutter/-/issues/2451 - Tests timeout with python-dbusmock < 0.28: https://gitlab.gnome.org/GNOME/mutter/-/issues/2452
In the interest of getting this into Gentoo so people can actually test it, I suggest that we remove IUSE=sound and leave libcanberra support enabled always and that we require python-dbusmock >= 0.28.
There was a problem hiding this comment.
There is still the problem that it fails to run for me on my openrc machine and works on a systemd laptop I have.
42.3 works fine on both.
Can we get someone else with a openrc machibe to test this so we don't break people's computers accidentally?
Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>
Schievel1
force-pushed
the
mutter-bump
branch
from
452b221
to
d7a09c4
Compare
Pull request CI reportReport generated at: 2022-09-19 10:52 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Schievel1
changed the title
Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>
Schievel1
force-pushed
the
mutter-bump
branch
2 times, most recently
from
1e93532
to
df2a657
Compare
Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>
Schievel1
force-pushed
the
mutter-bump
branch
from
df2a657
to
7a30c06
Compare
Schievel1
changed the title
Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>
Pull request CI reportReport generated at: 2022-09-21 10:32 UTC New issues caused by PR: There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Please drop the |
| -Dinstalled_tests=false | ||
| $(meson_use !test skip_dbus_tests) | ||
| $(meson_use !test skip_gtk_tests) | ||
| -Db_pch=True # TODO this has to go |
There was a problem hiding this comment.
So remove it? :)
Without it, I see that the build fails. Any idea why?
There was a problem hiding this comment.
Looks like you filed https://gitlab.gnome.org/GNOME/gjs/-/issues/509 for this.
| python_has_version "dev-python/python-dbusmock[${PYTHON_USEDEP}]" | ||
| fi | ||
| } | ||
|
|
There was a problem hiding this comment.
Let's add this here:
+src_prepare() {
+ default
+
+ sed -i -e "s:#!/usr/bin/bash:#!$(command -v bash):" src/tests/x11-test.sh || die
+}as that script has a shebang of #!/usr/bin/bash.
Required gcr-3.90.0 in #27331