distutils_install_for testing install proper egg-info, dev-python/cryptography fix test on first install #2746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgorny
reviewed
Nov 5, 2016
| mkdir -p "${libdir}" || die | ||
| esetup.py "${add_args[@]}" "${@}" | ||
| esetup.py "${add_args_egg[@]}" | ||
| esetup.py "${add_args_install[@]}" "${@}" |
There was a problem hiding this comment.
Any reason not to pass both in a single call?
There was a problem hiding this comment.
Other than for the sake of clarity... no I guess?
There was a problem hiding this comment.
Then plus combine that into a single array, and a single call. Two arrays don't make it more readable, and remember that parameters to command also influence behavior of other commands in distutils.
mgorny
added
enhancement
assigned
|
CC @gentoo/python. |
|
LGTM. |
|
I'm a bit confused as to why |
|
@floppym the install puts in some egg-info but not everything and for some reason this seems to be desired behaviour... |
mgorny
approved these changes
Nov 6, 2016
…t install On first install the test would fail because it uses introspection but the egg-info was not available. On second install it would work because introspection would (wrongly) inspect the system installed package. Added distutils_install_for_testing to have a complete install available for testing. Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=595272 Package-Manager: portage-2.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently distutils_install_for_testing does not install the complete
egg-info into ${TEST_DIR}. This was first noticed by W. Trevor King and
reported in bug #524322. Based on info found in the related upstream
setuptools bug I added the necessary call to setuptools to create the
complete egg_info.
Without this certain packages (like cryptography) fail during testing
because they use introspection but the metadata isn't available.
Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=595272
Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=524322