Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-boot/refind: prevent from using user's CFLAGS (bug #598587) #2754

Closed
wants to merge 1 commit into from

Conversation

sveyret
Copy link
Contributor

@sveyret sveyret commented Nov 5, 2016

After our discussion on proxy maintainers IRC, here is the correction, removing the ability to use users CFLAGS or LDFLAGS for compiling EFI, which is not Linux application.
Please review @gktrk @wraeth
Note that this will also make the bug #598004 become not not applicable.

@gktrk
Copy link
Member

gktrk commented Nov 6, 2016

@gentoo/proxy-maint

@gktrk gktrk added bugfix assigned PR successfully assigned to the package maintainer(s). labels Nov 6, 2016
@gktrk
Copy link
Member

gktrk commented Nov 6, 2016

We should revbump all these ebuilds to trigger a rebuild on systems that built a non-functional refind.

@sveyret
Copy link
Contributor Author

sveyret commented Nov 6, 2016

@gktrk Done.

@gktrk
Copy link
Member

gktrk commented Nov 6, 2016

the point of the revbump is to leave the previous revision untouched :)

@gktrk
Copy link
Member

gktrk commented Nov 6, 2016

I should probably clarify my previous comment. when we make a revbump, we want to create the revision bumped files with the changes we want first, and then possibly remove the previous revisions.

…, bug #598587

Package-Manager: portage-2.3.0
@gentoo-repo-qa-bot
Copy link
Collaborator

👍 All QA issues have been fixed!

@gktrk
Copy link
Member

gktrk commented Nov 6, 2016

Merged in ef27371...6122936. Thanks!

@gktrk gktrk closed this Nov 6, 2016
@sveyret sveyret deleted the refind-cflags branch November 6, 2016 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s).
Projects
None yet
3 participants