Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-misc/icaclient: bump to version 22.9.0.21 and fix two bugs in all versions #27554

Closed
wants to merge 5 commits into from

Conversation

henning-schild
Copy link
Contributor

Signed-off-by: Henning Schild henning@hennsch.de

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @henning-schild
Areas affected: ebuilds
Packages affected: net-misc/icaclient

net-misc/icaclient: @henning-schild, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Oct 1, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-10-01 11:13 UTC
Newest commit scanned: b92d2b5
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/0622a244d3/output.html

@henning-schild
Copy link
Contributor Author

I also included a bugfix. Can reorder things if needed or propose as two MRs.

@henning-schild henning-schild changed the title net-misc/icaclient: bump to version 22.9.0.21 net-misc/icaclient: bump to version 22.9.0.21 and fix a bug in all versions Oct 1, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-10-01 11:47 UTC
Newest commit scanned: 3b61998
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4df65bffb9/output.html

@henning-schild henning-schild changed the title net-misc/icaclient: bump to version 22.9.0.21 and fix a bug in all versions net-misc/icaclient: bump to version 22.9.0.21 and fix two bugs in all versions Oct 1, 2022
@henning-schild
Copy link
Contributor Author

added another bugfix for https://bugs.gentoo.org/516590

@henning-schild
Copy link
Contributor Author

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-10-01 12:03 UTC
Newest commit scanned: 3d3106e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/94c96b4d86/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-10-11 21:48 UTC
Newest commit scanned: 8ad1e57
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/bb559163af/output.html

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* QA Notice: Unresolved soname dependencies:
 * 
 * 	/opt/Citrix/ICAClient/AUDPULSE.DLL: libpulse.so.0
 * 	/opt/Citrix/ICAClient/VDGSTCAM.DLL: libpulse.so.0
 * 	/opt/Citrix/ICAClient/VDHSSPI.DLL: libgssapi.so.3
 * 	/opt/Citrix/ICAClient/lib/libkcph.so: libgssapi.so.3
 * 	/opt/Citrix/ICAClient/lib/libwebrpc.so: libunwind.so.1
 * 	/opt/Citrix/ICAClient/util/HdxRtcEngine: libunwind.so.1
 * 	/opt/Citrix/ICAClient/util/gst_aud_play: libgstapp-0.10.so.0 libgstbase-0.10.so.0 libgstreamer-0.10.so.0
 * 	/opt/Citrix/ICAClient/util/gst_aud_read: libgstapp-0.10.so.0 libgstreamer-0.10.so.0
 * 	/opt/Citrix/ICAClient/util/gst_play0.10: libgstapp-0.10.so.0 libgstbase-0.10.so.0 libgstinterfaces-0.10.so.0 libgstreamer-0.10.so.0
 * 	/opt/Citrix/ICAClient/util/gst_read0.10: libgstapp-0.10.so.0 libgstpbutils-0.10.so.0 libgstreamer-0.10.so.0
 * 	/opt/Citrix/ICAClient/util/libgstflatstm0.10.so: libgstbase-0.10.so.0 libgstreamer-0.10.so.0
 * 

Looks like you're missing some deps from the package.

Also:

 * VDB: detected possibly incorrect RDEPEND (net-misc/icaclient-22.9.0.21-r1)
 *                          > app-accessibility/at-spi2-core:2
 * media-libs/libjpeg-turbo < 
 *                          > media-libs/mesa

(from iwdevtools qa-vdb)

@henning-schild
Copy link
Contributor Author

Good catch. I usually bump the ebuild on a desktop machine that just happens to have a lot of stuff installed. However i know by heart that some of the sonames are known https://bugs.gentoo.org/855374 . Not easy to solve and only limiting the functionality a bit. Here i hope citrix will eventually solve things, i did reach out to them via several channels.

So assume that i will be able to shrink that list, but not down to zero. The application simply has multiple implementations for audio, kerberos (https://bugs.gentoo.org/775995) etc. If some do not work it will find a working one, or an advanced feature might just not work while the general functionality will work. i.e. that missing pulse might well switch to no-audio or pipewire or alsa, or HdxRtcEngine will improve the audio experience when media-plugins/hdx-realtime-media-engine and MS Teams is used ... Not installing the libs and binaries is more risky then having them in place and not working ... in which case the client itself will remain functional. These multiple implementations ... like kerberos are in conflict on gentoo so we can never make that go away. And i rather not install only bits and risk breaking the fallback/impl-switching features of that application.

I can not test all combinations but would rather try and fix bugs like "audio not working" than trying to satisfy QA checks that only indicate potential problems. Not having the client at all or in an old version is more of a problem than a potentially not working sub-feature.

@henning-schild
Copy link
Contributor Author

I will be able to get rid of the libpulse things, the "gstream 0.10" came with 10d9f5b. They should be ignored.

The binaries for that one are not available for download anymore.

Closes: https://bugs.gentoo.org/874327
Signed-off-by: Henning Schild <henning@hennsch.de>
Signed-off-by: Henning Schild <henning@hennsch.de>
Not sure why this was added. The ebuilds work without it.

Closes: https://bugs.gentoo.org/516590
Signed-off-by: Henning Schild <henning@hennsch.de>
The tarball does contain a mime type info file, deploy that in our
ebuilds.

Closes: https://bugs.gentoo.org/844022
Signed-off-by: Henning Schild <henning@hennsch.de>
@henning-schild
Copy link
Contributor Author

qa-vdb findings have been fixed, and soname are back to a level we are used to ignore

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-10-14 09:19 UTC
Newest commit scanned: 799d17c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4eccce1432/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-10-14 09:54 UTC
Newest commit scanned: 4baa98f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/557387958a/output.html

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@henning-schild
Copy link
Contributor Author

Ohh ... i must have pushed 4baa98f to the wrong branch. Not sure how it was picked up ... it was meant for the future and to be discussed. But it made it in with dc67f8a ... so let us just go with that.

I will close some bugs.

@henning-schild henning-schild deleted the henning/staging5 branch October 14, 2022 20:50
@henning-schild
Copy link
Contributor Author

Let us see when we get reports on the use of REQUIRES_EXCLUDE ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants