Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sci-libs/vtk-9.1.0 - fix musl build #27626

Closed
wants to merge 2 commits into from
Closed

sci-libs/vtk-9.1.0 - fix musl build #27626

wants to merge 2 commits into from

Conversation

waebbl
Copy link
Contributor

@waebbl waebbl commented Oct 4, 2022

profiles: mask logging USE flag on sci-libs/vtk

The loguru module doesn't build on musl. Mask it until it's fixed
upstream.

sci-libs/vtk: fix build on musl

  • Add logging USE flag to be able to disable it for musl
  • Re-keyword temporarily dropped arm64

Bug: https://bugs.gentoo.org/873601
Signed-off-by: Bernd Waibel waebbl-gentoo@posteo.net

@waebbl
profiles: mask logging USE flag on sci-libs/vtk
696ac1f 
The loguru module doesn't build on musl. Mask it until it's fixed
upstream.

Bug: https://bugs.gentoo.org/873601
Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
@waebbl
sci-libs/vtk: fix build on musl
d9b108c 
- Add logging USE flag to be able to disable it for musl
- Re-keyword temporarily dropped arm64

Bug: https://bugs.gentoo.org/873601
Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @waebbl
Areas affected: ebuilds, profiles
Packages affected: sci-libs/vtk

sci-libs/vtk: @gentoo/sci, @waebbl, @gentoo/proxy-maint

Linked bugs

Bugs linked: 873601

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Oct 4, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-10-04 21:23 UTC
Newest commit scanned: d9b108c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e5422d328a/output.html

@waebbl
Copy link
Contributor Author

waebbl commented Oct 5, 2022

I probably should have used b.g.o. with a keyword request to re-add ~arm64 arch, removed in commit d46cf05,
If you insist on this way, just tell me and I'm going for it.

@thesamesam
Copy link
Member

thesamesam commented Oct 12, 2022 •
edited

I probably should have used b.g.o. with a keyword request to re-add ~arm64 arch, removed in commit d46cf05, If you insist on this way, just tell me and I'm going for it.

Yes please in future, but no worries for now.

@waebbl waebbl deleted the vtk-9.1-873601 branch October 13, 2022 06:29
@waebbl
Copy link
Contributor Author

waebbl commented Oct 13, 2022

Yes please in future, but no worries for now.

I will think about it in future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@waebbl @gentoo-bot @gentoo-repo-qa-bot @thesamesam