Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-analyzer/sslsplit: fix build with lld and cleanup #27631

Closed
wants to merge 4 commits into from

Conversation

arkamar
Copy link
Member

@arkamar arkamar commented Oct 5, 2022

  • this fixes link time issue when lld linker is used in multilib systems, see commit message for more info about the fix
  • I have appended github link to HOMEPAGE and break the variable to multiple lines
  • clean old 0.5.4
  • clean live, I don't want to take care of it anymore but anyone can easily create one from 0.5.5 if needed

Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
SSLsplit uses custom localization of libnet library which does not work
correctly in multilib environment. This commit fixes the issue by
restoring pkgconfig detection from upstream commit 46a55de8040a
("Refactor location of packages, improve libnet detection"). Similar
patch is also needed for tests, where libcrypto is also searched with
pkgconfig.

Closes: https://bugs.gentoo.org/731190
Closes: https://bugs.gentoo.org/874075
Signed-off-by: Petr Vaněk <arkamar@atlas.cz>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @arkamar
Areas affected: ebuilds
Packages affected: net-analyzer/sslsplit

net-analyzer/sslsplit: @arkamar, @gentoo/proxy-maint

Linked bugs

Bugs linked: 874075, 731190


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Oct 5, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-10-05 06:58 UTC
Newest commit scanned: 17ca09e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/20b33e7614/output.html

@gentoo-bot gentoo-bot closed this in 7bb7ed2 Oct 7, 2022
@arkamar arkamar deleted the sslsplit branch October 8, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
3 participants