Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-sound/supercollider: add 3.12.2, drop 3.11.2 #27643

Closed

Conversation

john-d-murphy
Copy link
Contributor

@john-d-murphy john-d-murphy commented Oct 5, 2022

Signed-off-by: John Murphy john.david.murphy@gmail.com

3.11.2 no longer compiles. Removing.

Removed Unneeded Patches:

  • media-sound/supercollider/files/supercollider-3.10.2-no-ccache.patch
  • media-sound/supercollider/files/supercollider-3.11.2-boost-1.74.patch
  • media-sound/supercollider/files/supercollider-3.11.2-fix-libscsynth-linker-issue.patch

Added Patch:

  • media-sound/supercollider/files/supercollider-3.12.2-remove-sndfile-redefinition.patch - Removes attempt to redefine struct defined in sndfile.h, but ordering of includes precludes removing the line entirely, as the build of other Ugens will fail.

Signed-off-by: John Murphy <john.david.murphy@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @john-d-murphy
Areas affected: ebuilds
Packages affected: media-sound/supercollider

media-sound/supercollider: @gentoo/proxy-maint (maintainer needed)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Oct 5, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-10-05 17:23 UTC
Newest commit scanned: c939609
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/9f7c4a0574/output.html

Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split this into two commits, one commit for adding a new version and 2nd commit for removing the old ones (+ patches).

Some use flag combinations won't compile, but please fix this easy one first:

 * QA Notice: new icons were found installed but icon cache
 * has not been updated:
 *   /usr/share/icons/hicolor/scalable/apps/sc_ide.svg
 *   /usr/share/icons/hicolor/32x32/apps/supercollider.xpm
 *   /usr/share/icons/hicolor/48x48/apps/supercollider.png
 * Please make sure to call xdg_icon_cache_update()
 * in pkg_postinst() and pkg_postrm() phases of appropriate pkgs.

You either need to use xdg.eclass or xdg-utils.eclass for that. Just ask away if you're unsure about something.

And you can force-push to this branch, no need to open a new PR.

@ghost
Copy link

ghost commented Dec 6, 2022

Kind ping: could you fix things asked by juippis?

@john-d-murphy
Copy link
Contributor Author

john-d-murphy commented Dec 6, 2022

Kind ping: could you fix things asked by juippis?

Yes - I can. I will be able to get to this next week after my finals. Been busy with work and school.

@ghost
Copy link

ghost commented Dec 6, 2022

Also, I see a patch was related to supercollider/supercollider#4991. Is it possible to drop it too on this version?

@a17r
Copy link
Member

a17r commented Dec 7, 2022

See also: https://bugs.gentoo.org/830825

@AndrewAmmerlaan
Copy link
Member

Closing since it seems the objective of this PR has been reached and it is now obsolete. Please re-open if this is not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits.
Projects
None yet
6 participants