New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
media-sound/supercollider: add 3.12.2, drop 3.11.2 #27643
Conversation
Signed-off-by: John Murphy <john.david.murphy@gmail.com>
Pull Request assignmentSubmitter: @john-d-murphy media-sound/supercollider: @gentoo/proxy-maint (maintainer needed) Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2022-10-05 17:23 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split this into two commits, one commit for adding a new version and 2nd commit for removing the old ones (+ patches).
Some use flag combinations won't compile, but please fix this easy one first:
* QA Notice: new icons were found installed but icon cache
* has not been updated:
* /usr/share/icons/hicolor/scalable/apps/sc_ide.svg
* /usr/share/icons/hicolor/32x32/apps/supercollider.xpm
* /usr/share/icons/hicolor/48x48/apps/supercollider.png
* Please make sure to call xdg_icon_cache_update()
* in pkg_postinst() and pkg_postrm() phases of appropriate pkgs.
You either need to use xdg.eclass or xdg-utils.eclass for that. Just ask away if you're unsure about something.
And you can force-push to this branch, no need to open a new PR.
Kind ping: could you fix things asked by juippis? |
Yes - I can. I will be able to get to this next week after my finals. Been busy with work and school. |
Also, I see a patch was related to supercollider/supercollider#4991. Is it possible to drop it too on this version? |
See also: https://bugs.gentoo.org/830825 |
Closing since it seems the objective of this PR has been reached and it is now obsolete. Please re-open if this is not the case. |
Signed-off-by: John Murphy john.david.murphy@gmail.com
3.11.2 no longer compiles. Removing.
Removed Unneeded Patches:
Added Patch: