Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-office/planner: new live ebuild, fix 814152, 784086 in old ebuild #27800

Closed
wants to merge 2 commits into from

Conversation

Schievel1
Copy link
Contributor

I prepared the 9999 ebuild to be used as a normal ebuild as well, once upstream has released a new version.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @Schievel1
Areas affected: ebuilds
Packages affected: app-office/planner

app-office/planner: @gentoo/gnome

Linked bugs

Bugs linked: 814152, 873853, 784086


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Oct 15, 2022
@Schievel1
Copy link
Contributor Author

I don't know why pkgcheck scan --net reports a dead URL here. The ebuild works fine, and yes I deleted the files in /var/cache/distfiles/ to make sure.

app-office/planner/planner-0.14.6_p20130520-r3.ebuild Outdated Show resolved Hide resolved
app-office/planner/planner-9999.ebuild Outdated Show resolved Hide resolved
app-office/planner/planner-9999.ebuild Outdated Show resolved Hide resolved
app-office/planner/planner-9999.ebuild Outdated Show resolved Hide resolved
app-office/planner/planner-9999.ebuild Outdated Show resolved Hide resolved
app-office/planner/planner-9999.ebuild Outdated Show resolved Hide resolved
app-office/planner/planner-9999.ebuild Outdated Show resolved Hide resolved
app-office/planner/planner-9999.ebuild Show resolved Hide resolved
app-office/planner/planner-9999.ebuild Outdated Show resolved Hide resolved
app-office/planner/planner-9999.ebuild Outdated Show resolved Hide resolved
app-office/planner/planner-9999.ebuild Outdated Show resolved Hide resolved
app-office/planner/planner-9999.ebuild Outdated Show resolved Hide resolved
@leio
Copy link
Member

leio commented Oct 16, 2022

Once we are done with reviews and are happy with everything else, we might want to not git mv the ebuild revision, but keep the old one too, depending on if we deem this OK to "straight to stable" or not. But until this is in review, the git mv is making the review much easier thanks to providing a diff instead of a full new file.

@leio
Copy link
Member

leio commented Oct 16, 2022

You also need gettext in BDEPEND - this is also missing from the autotools version, it looks like, but there it's pulled in indirectly by intltool - not the case with meson version anymore, and it's needed due to po/meson.build calling i18n.gettext() (the i18n might differ per projects, depends under what variable they imported the module, but there being a po/ folder is a good hint)

@leio
Copy link
Member

leio commented Oct 16, 2022

also need virtual/pkgconfig in the live ebuild in BDEPEND - if it's not present, most of the dependency() meson calls would fail

@Schievel1 Schievel1 force-pushed the gnome-planner-bump branch 2 times, most recently from d5bc39d to 1a94791 Compare October 16, 2022 20:04
@Schievel1
Copy link
Contributor Author

Once we are done with reviews and are happy with everything else, we might want to not git mv the ebuild revision, but keep the old one too, depending on if we deem this OK to "straight to stable" or not. But until this is in review, the git mv is making the review much easier thanks to providing a diff instead of a full new file.

Idk what is the standard procedure here and if we should follow it. After all this is the same stable program, for 10 years or so now.

@Schievel1 Schievel1 requested a review from leio October 18, 2022 07:39
Copy link
Member

@leio leio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now, except the non-live revbump should probably be a copy to new revision + ekeyword ~all on the new revision instead of a git mv with changes like in the PR. Though this allowed to review the changes much better, but is against policy to go in like that as straight to stable revbump to the main tree.

app-office/planner/planner-9999.ebuild Outdated Show resolved Hide resolved
Closes: https://bugs.gentoo.org/814152
Closes: https://bugs.gentoo.org/784086

Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>
This ebuild already drops the gnome-base/gconf dep,
once there is a new release from upstream, remove the old ebuild and close
Bug: https://bugs.gentoo.org/873853

Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>
@Schievel1
Copy link
Contributor Author

Schievel1 commented Oct 23, 2022

This looks good to me now, except the non-live revbump should probably be a copy to new revision + ekeyword ~all on the new revision instead of a git mv with changes like in the PR. Though this allowed to review the changes much better, but is against policy to go in like that as straight to stable revbump to the main tree.

Yup, did that. So unchanged r2 is back and r3 has the changes and is all unstable. I think we don't need to bother to stabilize r3, since you are releasing a new version anyway soon.

@Schievel1 Schievel1 requested a review from leio October 24, 2022 05:56
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-10-24 13:23 UTC
Newest commit scanned: 4c09fe5
Status: ❌ broken

New issues caused by PR:
https://qa-reports.gentoo.org/output/gentoo-ci/bd08030ffd/output.html#app-office/planner

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/bd08030ffd/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants