New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-office/planner: new live ebuild, fix 814152, 784086 in old ebuild #27800
Conversation
Pull Request assignmentSubmitter: @Schievel1 app-office/planner: @gentoo/gnome Linked bugsBugs linked: 814152, 873853, 784086 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
ba6efb3
to
af867f9
Compare
I don't know why |
af867f9
to
d1c4490
Compare
d1c4490
to
16c3958
Compare
Once we are done with reviews and are happy with everything else, we might want to not |
You also need gettext in BDEPEND - this is also missing from the autotools version, it looks like, but there it's pulled in indirectly by intltool - not the case with meson version anymore, and it's needed due to po/meson.build calling i18n.gettext() (the |
also need virtual/pkgconfig in the live ebuild in BDEPEND - if it's not present, most of the |
d5bc39d
to
1a94791
Compare
Idk what is the standard procedure here and if we should follow it. After all this is the same stable program, for 10 years or so now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now, except the non-live revbump should probably be a copy to new revision + ekeyword ~all
on the new revision instead of a git mv
with changes like in the PR. Though this allowed to review the changes much better, but is against policy to go in like that as straight to stable revbump to the main tree.
1a94791
to
22b6a4d
Compare
Closes: https://bugs.gentoo.org/814152 Closes: https://bugs.gentoo.org/784086 Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>
This ebuild already drops the gnome-base/gconf dep, once there is a new release from upstream, remove the old ebuild and close Bug: https://bugs.gentoo.org/873853 Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>
22b6a4d
to
4c09fe5
Compare
Yup, did that. So unchanged r2 is back and r3 has the changes and is all unstable. I think we don't need to bother to stabilize r3, since you are releasing a new version anyway soon. |
Pull request CI reportReport generated at: 2022-10-24 13:23 UTC New issues caused by PR: There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
I prepared the 9999 ebuild to be used as a normal ebuild as well, once upstream has released a new version.