Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-office/scribus: optfeature antiword #27826

Closed
wants to merge 1 commit into from

Conversation

jeffgazso
Copy link
Contributor

Signed-off-by: Jeffery Gazso jeff.gazso@gmail.com

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @jeffgazso
Areas affected: ebuilds
Packages affected: app-office/scribus

app-office/scribus: @fordfrog

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Oct 18, 2022
@jeffgazso
Copy link
Contributor Author

Adds app-text/antiword as an optfeature enabling MS Word legacy .doc file import support if installed. Let me know if this one looks better @thesamesam or if anything needs to be amended.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-10-18 00:24 UTC
Newest commit scanned: 778313b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/d2f0a2431c/output.html

@jeffgazso
Copy link
Contributor Author

@thesamesam, let me know if there is anything I need to do to move this PR forward.

@thesamesam
Copy link
Member

thesamesam commented Oct 20, 2022

It's only been 2 days total. Not had a chance to look again yet.

We usually ask people to wait 2 weeks before pinging unless it's urgent.

@jeffgazso
Copy link
Contributor Author

@thesamesam, Oops, sorry. I haven't gotten a feel for Gentoo's operational tempo for things like PR's yet. I wasn't trying to be a pain.

@thesamesam
Copy link
Member

git author is still wrong: Author: Your Name <you@example.com> (also, we need to put xdg_pkg_postinst in pkg_postinst() as you're now shadowing the eclass call, but rI can do that on merge).

@thesamesam
Copy link
Member

ping

@jeffgazso
Copy link
Contributor Author

@thesamesam thanks for the ping, this completely slipped my mind.

So, as far as I can see on my end everything looks right. I do not see Author: Your Name <you@example.com> anywhere. Every git command I can think to run shows my info instead. Obviously there is something I'm missing because you see something different.

I don't want to make an annoyance of myself by attempting to troubleshoot this over the comments in a PR request. I'm going to go post on the forum, reference this bug, and ask for pointers. Thanks again for the reminder.

@jeffgazso
Copy link
Contributor Author

jeffgazso commented Dec 24, 2022

With the help of some nice folks on the forum, I have spotted the likely reason Author: Your Name <you@example.com> was set. It's fixed now. Now I've got a few other minor things to figure out and then I'll push this up. It's Christmas Eve here, so give me a bit.

Signed-off-by: Jeffery Gazso <jeff.gazso@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-12-29 00:38 UTC
Newest commit scanned: 4e50dbe
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/7e1521f32a/output.html

@jeffgazso
Copy link
Contributor Author

I ran a git commit --amend -s it shows my name and not boilerplate on this end. With that set, I pushed it out. Let me know if something still isn't right.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-12-29 00:48 UTC
Newest commit scanned: 2af2d90
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/e5971d9a47/output.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants