New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
games-action/prismlauncher: new package #27860
Conversation
This is mostly an adaptation of the games-action/polymc ebuild, considering we're a 2-day old fork of it. Signed-off-by: Thiago Donato Ferreira <flowlnlnln@gmail.com>
THis replaces the bundled one, like what's done with quazip. Signed-off-by: Thiago Donato Ferreira <flowlnlnln@gmail.com>
Signed-off-by: Thiago Donato Ferreira <flowlnlnln@gmail.com>
Pull Request assignmentSubmitter: @flowln games-action/prismlauncher: @gentoo/proxy-maint (new package) Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. New packagesThis Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Pull request CI reportReport generated at: 2022-10-19 22:38 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
I've added a runtime blocker on polymc. I guess we may need one for polymc-bin to be polite to GURU users?
File a bug in Gentoo Linux -> Keywording. In package list, put "games-action/prismlauncher ~arm64", and add CC-ARCHES to the KEYWORDS field. Yeah, definitely sounds like we should avoid arm for now.
|
They may install the same JAR files. Bug: #27860 Signed-off-by: Sam James <sam@gentoo.org>
Thanks! |
Thank you @flowln (and others) for your fast reaction and solution to this unfortunate situation. |
Btw, can we also keyword it on x86, or does it not work on this arch? |
should work on x86 but Minecraft itself (1.13+) won't run |
Following the conversation about the PolyMC hijacking:
This is a fork of PolyMC (
games-action/polymc
) made by the previous maintainers that got thrown off by one of the other maintainers in a hostile takeover. Being a new fork, the ebuilds are based on the previous live ebuild from polymc, with the following changes made to the package:::gentoo
repository (dev-cpp/gulrak-filesystem
). So, I've added it toBDEPEND
and left it out of the submodules list, like what was done with quazip. I tested unmerging it afterwards, and there was no problem with Prism, so there's no linking dependency after.There may also be some problems if trying to emerge PrismLauncher with PolyMC installed, due to them installing the same JAR files in the same locations. I'm not sure what to do here, should I add something to
RESTRICT
?If this gets added to the tree, I'm also planning to request for
~arm64
keywording on Bugzilla, since the release has added support for it (no arm32 yet though, because there seems to be some issues going on atm). If anyone can point me to what exactly I need to do for that, I'd be very grateful. 😁Thank you!