Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

games-action/prismlauncher: new package #27860

Closed
wants to merge 3 commits into from

Conversation

flowln
Copy link
Contributor

@flowln flowln commented Oct 19, 2022

Following the conversation about the PolyMC hijacking:

This is a fork of PolyMC (games-action/polymc) made by the previous maintainers that got thrown off by one of the other maintainers in a hostile takeover. Being a new fork, the ebuilds are based on the previous live ebuild from polymc, with the following changes made to the package:

  • Since the last stable release of PolyMC, one more submodule was added, and we have a version of it in the ::gentoo repository (dev-cpp/gulrak-filesystem). So, I've added it to BDEPEND and left it out of the submodules list, like what was done with quazip. I tested unmerging it afterwards, and there was no problem with Prism, so there's no linking dependency after.
  • I've removed Carson Rueter from the maintainers list, considering he seems to be aligned with LennyMcLennington, the maintainer that hijacked PolyMC. If this is a mistake, please come forwards.

There may also be some problems if trying to emerge PrismLauncher with PolyMC installed, due to them installing the same JAR files in the same locations. I'm not sure what to do here, should I add something to RESTRICT?

If this gets added to the tree, I'm also planning to request for ~arm64 keywording on Bugzilla, since the release has added support for it (no arm32 yet though, because there seems to be some issues going on atm). If anyone can point me to what exactly I need to do for that, I'd be very grateful. 😁

Thank you!

This is mostly an adaptation of the games-action/polymc ebuild,
considering we're a 2-day old fork of it.

Signed-off-by: Thiago Donato Ferreira <flowlnlnln@gmail.com>
THis replaces the bundled one, like what's done with quazip.

Signed-off-by: Thiago Donato Ferreira <flowlnlnln@gmail.com>
Signed-off-by: Thiago Donato Ferreira <flowlnlnln@gmail.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @flowln
Areas affected: ebuilds
Packages affected: games-action/prismlauncher

games-action/prismlauncher: @gentoo/proxy-maint (new package)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Oct 19, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-10-19 22:38 UTC
Newest commit scanned: 4d44ad3
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b5d1fca113/output.html

@thesamesam
Copy link
Member

Following the conversation about the PolyMC hijacking:

This is a fork of PolyMC (games-action/polymc) made by the previous maintainers that got thrown off by one of the other maintainers in a hostile takeover. Being a new fork, the ebuilds are based on the previous live ebuild from polymc, with the following changes made to the package:

* Since the last stable release of PolyMC, one more submodule was added, and we have a version of it in the `::gentoo` repository (`dev-cpp/gulrak-filesystem`). So, I've added it to `BDEPEND` and left it out of the submodules list, like what was done with quazip. I tested unmerging it afterwards, and there was no problem with Prism, so there's no linking dependency after.

* I've removed Carson Rueter from the maintainers list, considering he seems to be aligned with LennyMcLennington, the maintainer that hijacked PolyMC. If this is a mistake, please come forwards.

There may also be some problems if trying to emerge PrismLauncher with PolyMC installed, due to them installing the same JAR files in the same locations. I'm not sure what to do here, should I add something to RESTRICT?

I've added a runtime blocker on polymc. I guess we may need one for polymc-bin to be polite to GURU users?

If this gets added to the tree, I'm also planning to request for ~arm64 keywording on Bugzilla, since the release has added support for it (no arm32 yet though, because there seems to be some issues going on atm). If anyone can point me to what exactly I need to do for that, I'd be very grateful. 😁

File a bug in Gentoo Linux -> Keywording. In package list, put "games-action/prismlauncher ~arm64", and add CC-ARCHES to the KEYWORDS field.

Yeah, definitely sounds like we should avoid arm for now.

Thank you!

gentoo-bot pushed a commit that referenced this pull request Oct 20, 2022
They may install the same JAR files.

Bug: #27860
Signed-off-by: Sam James <sam@gentoo.org>
@thesamesam
Copy link
Member

Thanks!

@AndrewAmmerlaan
Copy link
Member

Thank you @flowln (and others) for your fast reaction and solution to this unfortunate situation.

@AndrewAmmerlaan
Copy link
Member

If this gets added to the tree, I'm also planning to request for ~arm64 keywording on Bugzilla, since the release has added support for it (no arm32 yet though, because there seems to be some issues going on atm). If anyone can point me to what exactly I need to do for that, I'd be very grateful. grin

File a bug in Gentoo Linux -> Keywording. In package list, put "games-action/prismlauncher ~arm64", and add CC-ARCHES to the KEYWORDS field.

Btw, can we also keyword it on x86, or does it not work on this arch?

@DioEgizio
Copy link

should work on x86 but Minecraft itself (1.13+) won't run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
6 participants