Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sci-libs/pcl: fix several issues #27977

Closed
wants to merge 2 commits into from
Closed

Conversation

waebbl
Copy link
Contributor

@waebbl waebbl commented Oct 27, 2022

  • enable cuda sandbox to avoid sandbox violation, #869674
  • patch the code for several installation directories to conform to FHS. This is just a hack and should be done using GNUInstallDirs and provided upstream to solve it properly, #853886
  • add a dependency on virtual/latex-base to avoid an additional QA issue on latex not found, because the doxyfile uses LaTeX by default. Also depend on doxygen[dot] to avoid a cmake warning about missing doxygen component
  • change test related cmake option to new value to avoid undefined cmake variables, #738996
  • depend on dev-python/sphinx_rtd_theme to properly build tutorial docs with USE=tutorials, #849002
  • restrict test, because it needs the gtest sources to be provided, the package alone seems not be enough.

Closes: https://bugs.gentoo.org/869674
Closes: https://bugs.gentoo.org/853886
Closes: https://bugs.gentoo.org/738996
Closes: https://bugs.gentoo.org/849002

Signed-off-by: Bernd Waibel waebbl-gentoo@posteo.net

This PR is, strictly speaking, not restricted to a single topic. The single topic would be solving issues. If you prefer to have split this into several topic related PRs, just ping me and I split it.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @waebbl
Areas affected: ebuilds
Packages affected: sci-libs/pcl

sci-libs/pcl: aballier

At least one of the listed packages is maintained entirely by non-GitHub developers!

Linked bugs

Bugs linked: 869674, 738996, 853886, 849002


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added need assignment It was impossible to assign the PR correctly. Please assign it manually. bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Oct 27, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-10-27 11:18 UTC
Newest commit scanned: 195055e
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/c38fcad205/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-10-27 11:48 UTC
Newest commit scanned: 8e54703
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b73135389e/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-10-27 16:08 UTC
Newest commit scanned: 507a5a9
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/180ad5cd11/output.html

@waebbl
Copy link
Contributor Author

waebbl commented Oct 28, 2022

I've reported the possibility to improve the installation handling using GNUInstallDirs in PointCloudLibrary/pcl#5496

- enable cuda sandbox to avoid sandbox violation, #869674
- patch the code for several installation directories to conform to FHS. This
  is just a hack and should be done using GNUInstallDirs and provided upstream
  to solve it properly, #853886
- add a dependency on virtual/latex-base to avoid an additional QA issue
  on latex not found, because the doxyfile uses LaTeX by default. Also depend
  on doxygen[dot] to avoid a cmake warning about missing doxygen component
- change test related cmake option to new value to avoid undefined cmake
  variables, #738996
- depend on dev-python/sphinx_rtd_theme to properly build tutorial docs
  with USE=tutorials, #849002
- restrict test, because it needs the gtest sources to be provided, the
  package alone seems not be enough.
- fix hardcoded path for cmake files to be installed into /usr/share/cmake/

Closes: https://bugs.gentoo.org/869674
Closes: https://bugs.gentoo.org/853886
Closes: https://bugs.gentoo.org/738996
Closes: https://bugs.gentoo.org/849002

Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
@waebbl
Copy link
Contributor Author

waebbl commented Oct 28, 2022

I ported the changes to the live ebuild as well.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-10-28 11:48 UTC
Newest commit scanned: 2c96033
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8ec9401feb/output.html

@waebbl waebbl deleted the pcl-cuda-fix branch November 13, 2022 00:05
@waebbl
Copy link
Contributor Author

waebbl commented Nov 13, 2022

Thanks @SoapGentoo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug linked Bug/Closes found in footer, and cross-linked with the PR. need assignment It was impossible to assign the PR correctly. Please assign it manually.
Projects
None yet
4 participants