-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-python/{shibokent6,pyside6,pyside6-tools} - bump to 6.4.0 #28000
Conversation
Pull request CI reportReport generated at: 2022-10-28 10:08 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Need to restrict to <clang-16 for now, bug #873391 Bug: https://bugs.gentoo.org/873391 Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
- add charts and network-auth modules - add templates for httpserver, pdf{,widgets} and spatialaudio modules - adjust some required use and outdated dependencies Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
4d60835
to
155d95c
Compare
Should be ready for review. Hopefully I catched any detail. On a side note: I'd like to have the essential modules removed from the USE flags. These are Core, Gui, Widgets, PrintSupport, Sql, Network, Test(lib), Concurrent:
|
Pull Request assignmentSubmitter: @waebbl dev-python/pyside6: @AndrewAmmerlaan, @waebbl Linked bugsBugs linked: 873391 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Great, Thanks, I'll test and merge soon (probably this weekend).
I'd like to keep pyside{2,6} as close as possible to pyqt{5,6}. This makes maintaining QtPy a bit easier. So I think we should discuss this first with the Qt Team. |
Pull request CI reportReport generated at: 2022-11-03 14:43 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
That's ok. I don't know the build systems of PyQt or QtPy, but it seems, like PySide is quite sensitive when it comes to potentially invalid combinations of build time options. Although it does allow them, it at least gives warnings, but silently disables the requested features. |
Sure, that is what I meant (but said a bit unclearly): Minimal differences between PyQt5/Pyside2, and minimal differences between PyQt6/Pyside6, but the Qt5 and Qt6 stuff can of course be different from each other. |
Another note: the patch for bug #873391 should eventually also be applied to shiboken2-5.15.5 and shiboken6-6.3.2. If 5.15.6 and 6.4.0 are failing with clang-16 so most like will also do the earlier versions. I didn't include it here, because it's a different topic. |
Additionally, we need to be a bit stricter in which versions of the qt packages we pull in. For example, pyside 6.3.2 fails to compile with qtbase 6.4.0. I'll fix this in a followup commit. |
Great work, Thanks 👍 |
Yes, they started with some pyside2-5.x version to be stricter, yet didn't require the exact same version then. Maybe we should handle these package the same way as any other Qt package and strictly require the same version? |
Thanks for merging! 👍 |
dev-python/shiboken6: add 6.4.0
Need to restrict to <clang-16 for now, bug #873391
Bug: https://bugs.gentoo.org/873391
Signed-off-by: Bernd Waibel waebbl-gentoo@posteo.net
dev-python/pyside6: add 6.4.0
Signed-off-by: Bernd Waibel waebbl-gentoo@posteo.net
dev-python/pyside6-tools: add 6.4.0
Signed-off-by: Bernd Waibel waebbl-gentoo@posteo.net