Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-python/{shibokent6,pyside6,pyside6-tools} - bump to 6.4.0 #28000

Closed
wants to merge 3 commits into from

Conversation

waebbl
Copy link
Contributor

@waebbl waebbl commented Oct 28, 2022

dev-python/shiboken6: add 6.4.0

Need to restrict to <clang-16 for now, bug #873391

Bug: https://bugs.gentoo.org/873391
Signed-off-by: Bernd Waibel waebbl-gentoo@posteo.net

dev-python/pyside6: add 6.4.0

  • add charts and network-auth modules
  • add templates for httpserver, pdf{,widgets} and spatialaudio modules
  • adjust some required use and outdated dependencies

Signed-off-by: Bernd Waibel waebbl-gentoo@posteo.net

dev-python/pyside6-tools: add 6.4.0

Signed-off-by: Bernd Waibel waebbl-gentoo@posteo.net

@waebbl waebbl marked this pull request as draft October 28, 2022 09:51
@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Oct 28, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-10-28 10:08 UTC
Newest commit scanned: 4d60835
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b89d86ea56/output.html

Need to restrict to <clang-16 for now, bug #873391

Bug: https://bugs.gentoo.org/873391
Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
- add charts and network-auth modules
- add templates for httpserver, pdf{,widgets} and spatialaudio modules
- adjust some required use and outdated dependencies

Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
@waebbl
Copy link
Contributor Author

waebbl commented Nov 3, 2022

Should be ready for review. Hopefully I catched any detail.

On a side note: I'd like to have the essential modules removed from the USE flags. These are Core, Gui, Widgets, PrintSupport, Sql, Network, Test(lib), Concurrent:

  • fewer USE flags -> easier testing
  • greatly simplified logic for REQUIRED_USE
  • although the package builds with these modules off, testing is not supported by such configurations according to the output from cmake
  • configurations with essential modules disabled call for issues, with might not be easy to catch or analyze
    WDYT?

@waebbl waebbl marked this pull request as ready for review November 3, 2022 14:27
@waebbl waebbl changed the title dev-python/{shibokent6,pyside6,pyside6-tools} - bump to 6.4.0 dev-python/{shibokent6,pyside6,pyside6-tools} - bump to 6.4.0[please reassign] Nov 3, 2022
@gentoo-bot gentoo-bot changed the title dev-python/{shibokent6,pyside6,pyside6-tools} - bump to 6.4.0[please reassign] dev-python/{shibokent6,pyside6,pyside6-tools} - bump to 6.4.0 Nov 3, 2022
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @waebbl
Areas affected: ebuilds
Packages affected: dev-python/pyside6, dev-python/pyside6-tools, dev-python/shiboken6

dev-python/pyside6: @AndrewAmmerlaan, @waebbl
dev-python/pyside6-tools: @AndrewAmmerlaan, @waebbl
dev-python/shiboken6: @AndrewAmmerlaan, @waebbl

Linked bugs

Bugs linked: 873391


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) labels Nov 3, 2022
@AndrewAmmerlaan
Copy link
Member

Should be ready for review. Hopefully I catched any detail.

Great, Thanks, I'll test and merge soon (probably this weekend).

On a side note: I'd like to have the essential modules removed from the USE flags. These are Core, Gui, Widgets, PrintSupport, Sql, Network, Test(lib), Concurrent:

* fewer USE flags -> easier testing

* greatly simplified logic for REQUIRED_USE

* although the package builds with these modules off, testing is not supported by such configurations according to the output from cmake

* configurations with essential modules disabled call for issues, with might not be easy to catch or analyze
  WDYT?

I'd like to keep pyside{2,6} as close as possible to pyqt{5,6}. This makes maintaining QtPy a bit easier. So I think we should discuss this first with the Qt Team.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-11-03 14:43 UTC
Newest commit scanned: 155d95c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a6c88d8e09/output.html

@waebbl
Copy link
Contributor Author

waebbl commented Nov 3, 2022

I'd like to keep pyside{2,6} as close as possible to pyqt{5,6}. This makes maintaining QtPy a bit easier. So I think we should discuss this first with the Qt Team.

That's ok. I don't know the build systems of PyQt or QtPy, but it seems, like PySide is quite sensitive when it comes to potentially invalid combinations of build time options. Although it does allow them, it at least gives warnings, but silently disables the requested features.
I see no reason however, why we should not depart from the pyside2 / pyqt5 set of USE flags. Qt6 is something new, it doesn't have to have the same set of options as Qt5.

@AndrewAmmerlaan
Copy link
Member

I see no reason however, why we should not depart from the pyside2 / pyqt5 set of USE flags. Qt6 is something new, it doesn't have to have the same set of options as Qt5.

Sure, that is what I meant (but said a bit unclearly): Minimal differences between PyQt5/Pyside2, and minimal differences between PyQt6/Pyside6, but the Qt5 and Qt6 stuff can of course be different from each other.

@waebbl
Copy link
Contributor Author

waebbl commented Nov 3, 2022

Another note: the patch for bug #873391 should eventually also be applied to shiboken2-5.15.5 and shiboken6-6.3.2. If 5.15.6 and 6.4.0 are failing with clang-16 so most like will also do the earlier versions. I didn't include it here, because it's a different topic.
Also I wasn't sure about the cleanup plans for these versions.

@AndrewAmmerlaan
Copy link
Member

Another note: the patch for bug #873391 should eventually also be applied to shiboken2-5.15.5 and shiboken6-6.3.2. If 5.15.6 and 6.4.0 are failing with clang-16 so most like will also do the earlier versions. I didn't include it here, because it's a different topic. Also I wasn't sure about the cleanup plans for these versions.

Additionally, we need to be a bit stricter in which versions of the qt packages we pull in. For example, pyside 6.3.2 fails to compile with qtbase 6.4.0. I'll fix this in a followup commit.

@gentoo-bot gentoo-bot closed this in f9e2e10 Nov 7, 2022
@AndrewAmmerlaan
Copy link
Member

Great work, Thanks 👍

@waebbl
Copy link
Contributor Author

waebbl commented Nov 7, 2022

Another note: the patch for bug #873391 should eventually also be applied to shiboken2-5.15.5 and shiboken6-6.3.2. If 5.15.6 and 6.4.0 are failing with clang-16 so most like will also do the earlier versions. I didn't include it here, because it's a different topic. Also I wasn't sure about the cleanup plans for these versions.

Additionally, we need to be a bit stricter in which versions of the qt packages we pull in. For example, pyside 6.3.2 fails to compile with qtbase 6.4.0. I'll fix this in a followup commit.

Yes, they started with some pyside2-5.x version to be stricter, yet didn't require the exact same version then. Maybe we should handle these package the same way as any other Qt package and strictly require the same version?

@waebbl
Copy link
Contributor Author

waebbl commented Nov 7, 2022

Thanks for merging! 👍

@waebbl waebbl deleted the pyside6-6.4.0-bump branch November 7, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants