Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-r3.eclass: Add checkout dirs as "safe" directories #28154

Closed
wants to merge 1 commit into from

Conversation

mgorny
Copy link
Member

@mgorny mgorny commented Nov 6, 2022

Mark all checkout directories as "safe" to avoid dubious ownership errors with newer git versions when the checkout directory is accessed from src_install().

Bug: https://bugs.gentoo.org/879353
Signed-off-by: Michał Górny mgorny@gentoo.org

Mark all checkout directories as "safe" to avoid dubious ownership
errors with newer git versions when the checkout directory is accessed
from src_install().

Bug: https://bugs.gentoo.org/879353
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @mgorny
Areas affected: eclasses
Packages affected: (none)

@gentoo/github

Linked bugs

Bugs linked: 879353

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added need assignment It was impossible to assign the PR correctly. Please assign it manually. bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Nov 6, 2022
@thesamesam
Copy link
Member

@DarkDefender

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-11-06 07:43 UTC
Newest commit scanned: c19324d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/ea22d89ee3/output.html

@DarkDefender
Copy link
Contributor

Seems to work for me! :)

@gentoo-bot gentoo-bot closed this in 207a50d Nov 7, 2022
nedko added a commit to LADI/os-gentoo-overlay that referenced this pull request Jul 11, 2023
recent git implementations require safe.directory to work properly

https://bugs.gentoo.org/879353
gentoo/gentoo#28154

The current fix for #879353, commit 207a50da440b7c6bea060972a7684e792c2a84fc,
does not address the install, as observed in #1 (comment)

This is workaround for #1
The git eclass should handle this situation without ebuild workarounds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug linked Bug/Closes found in footer, and cross-linked with the PR. need assignment It was impossible to assign the PR correctly. Please assign it manually.
Projects
None yet
5 participants