Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-editors/bvi: fix CFLAGS handling #28199

Closed
wants to merge 1 commit into from
Closed

app-editors/bvi: fix CFLAGS handling #28199

wants to merge 1 commit into from

Conversation

Hawk777
Copy link
Contributor

@Hawk777 Hawk777 commented Nov 9, 2022

No description provided.

@Hawk777
app-editors/bvi: fix CFLAGS handling
12f6946 
* Add `-std=gnu89` as recommended as the way to build K&R-style code
  which will not break with Clang 16.
* Append, instead of overwriting, `CFLAGS`.
* Bump to EAPI 8 while at it.

Closes: https://bugs.gentoo.org/880309
Closes: https://bugs.gentoo.org/880393
Signed-off-by: Christopher Head <chead@chead.ca>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @Hawk777
Areas affected: ebuilds
Packages affected: app-editors/bvi

app-editors/bvi: bugs[at]chead.ca, @gentoo/proxy-maint

Linked bugs

Bugs linked: 880393, 880309

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Nov 9, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-11-09 05:43 UTC
Newest commit scanned: 12f6946
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a1211e176b/output.html

juippis
juippis approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this requires a revbump... but there was some condition when fixing CFLAGS did. @thesamesam comments?

Contribution is fine, it fixes the CFLAGS bug. Please ping me in a couple (~2) days if no one comments and I'll merge without revbumping, or rebase a non-revbump fix yourself.

@thesamesam
Copy link
Member

Sorry, missed this! Thanks for the ping juippis.

You debatably need one for "respect CFLAGS" because you could have totally wrongly compiled binaries (imagine where you need -mabi or whatever on arm & mips), but we often don't as it's often low risk. But another reason to for that is because sometimes it breaks things to actually respect flags.

As for Clang 16 fixes, you need them when there's possibly runtime breakage or changes in the generated code, but for this, that shouldn't be an issue as it's just about K&R decls (so an obsolete form of C which becomes banned rather than an actually dangerous construct like e.g. implicit func decls).

But I'll just leave the revbump as why not, because of the *FLAGS changes, even if not strictly required.

@Hawk777 Hawk777 deleted the bvi-flags branch December 26, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
5 participants
@Hawk777 @gentoo-bot @gentoo-repo-qa-bot @thesamesam @juippis